Cleanup env variable names

Cleanup env variable names

This CL cleans up any old m_pEnv variables to
be correctly named m_pFormFillEnv.

Committed: https://pdfium.googlesource.com/pdfium/+/8779fa8578cf3336ddd4473f833900aba2e595fb

[dsinclair, 2016-10-11 13:53:00]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 13:53:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 13:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 13:55:35]

Dry run: Try jobs failed on following builders:
  win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/b...)

[dsinclair, 2016-10-11 14:08:12]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-10-11 14:08:13]

PTAL.

[Tom Sepez, 2016-10-11 16:47:21]

lgtm

https://codereview.chromium.org/2412523002/diff/20001/fpdfsdk/fpdfformfill.cpp
File fpdfsdk/fpdfformfill.cpp (right):

https://codereview.chromium.org/2412523002/diff/20001/fpdfsdk/fpdfformfill.cp...
fpdfsdk/fpdfformfill.cpp:250: // thi and can just return the old Env. Otherwise,
we'll end up setting a new
nit: this

[dsinclair, 2016-10-12 12:43:00]

Description was changed from

==========
Cleanup GetEnv, GetSDKDocument and variable names

This CL removes the no longer needed |GetEnv| and |GetSDKDocument| methods as
they both just return |this|. It also cleans up any old m_pEnv variables to
be correctly named m_pFormFillEnv.
==========

to

==========
Cleanup env variable names

This CL cleans up any old m_pEnv variables to
be correctly named m_pFormFillEnv.
==========

[dsinclair, 2016-10-12 17:41:42]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 17:41:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 17:43:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 17:43:23]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)

[dsinclair, 2016-10-12 18:57:09]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 18:57:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-12 19:01:43]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-10-12 19:01:43]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-12 19:01:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2412523002/#ps60001
(title: "Fix spelling")

[commit-bot: I haz the power, 2016-10-12 19:01:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:05:47]

Description was changed from

==========
Cleanup env variable names

This CL cleans up any old m_pEnv variables to
be correctly named m_pFormFillEnv.
==========

to

==========
Cleanup env variable names

This CL cleans up any old m_pEnv variables to
be correctly named m_pFormFillEnv.

Committed:
https://pdfium.googlesource.com/pdfium/+/8779fa8578cf3336ddd4473f833900aba2e5...
==========

[commit-bot: I haz the power, 2016-10-12 19:05:49]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/8779fa8578cf3336ddd4473f833900aba2e5...