Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2412513004: Revert the comment change in ServiceWorkerGlobalScopeProxy.cpp of https://crrev.com/2376403004 (Closed)

Created:
4 years, 2 months ago by horo
Modified:
4 years, 2 months ago
Reviewers:
falken, keishi
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert the comment change in ServiceWorkerGlobalScopeProxy.cpp of https://crrev.com/2376403004 We still start the service worker for ForeignFetch even if its Origin-Trial tokens have expired. So this comment change is unsuitable. BUG=649558 Committed: https://crrev.com/908845d683ec7a597592e32c05e077b8dc95a9a9 Cr-Commit-Position: refs/heads/master@{#424948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
horo
falken@ Could you please review?
4 years, 2 months ago (2016-10-12 08:20:07 UTC) #2
falken
lgtm with nits on CL description: - https://crrev.com/2343553003 links to the wrong thing - BUG=649558 ...
4 years, 2 months ago (2016-10-13 00:28:29 UTC) #3
horo
On 2016/10/13 00:28:29, falken wrote: > lgtm with nits on CL description: > - https://crrev.com/2343553003 ...
4 years, 2 months ago (2016-10-13 01:41:42 UTC) #7
horo
keishi@ Please review this.
4 years, 2 months ago (2016-10-13 01:42:43 UTC) #9
keishi
LGTM
4 years, 2 months ago (2016-10-13 01:46:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412513004/1
4 years, 2 months ago (2016-10-13 02:17:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 03:38:48 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 03:43:53 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/908845d683ec7a597592e32c05e077b8dc95a9a9
Cr-Commit-Position: refs/heads/master@{#424948}

Powered by Google App Engine
This is Rietveld 408576698