Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1380)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 24125005: Do not evaluate inlined field initializations twice in a redirecting constructor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/evaluation_redirecting_constructor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 27526)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -1414,10 +1414,14 @@
}
}
- inlinedFrom(callee, () {
- buildFieldInitializers(callee.enclosingElement.implementation,
+ // For redirecting constructors, the fields have already been
+ // initialized by the caller.
+ if (callee.getEnclosingClass() != caller.getEnclosingClass()) {
+ inlinedFrom(callee, () {
+ buildFieldInitializers(callee.enclosingElement.implementation,
fieldValues);
- });
+ });
+ }
int index = 0;
FunctionSignature params = callee.computeSignature(compiler);
« no previous file with comments | « no previous file | tests/language/evaluation_redirecting_constructor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698