Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 24125004: Add histograms tracking hit rate of Blink's in-memory cache. (Closed)

Created:
7 years, 3 months ago by Philippe
Modified:
7 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add histograms tracking hit rate of Blink's in-memory cache. This is needed to track possible improvements in Blink's in-memory cache. BUG=290193 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223617

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ilya's comments #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Philippe
7 years, 3 months ago (2013-09-16 14:44:13 UTC) #1
Ilya Sherman
LGTM % nit. https://codereview.chromium.org/24125004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/24125004/diff/1/tools/metrics/histograms/histograms.xml#newcode24226 tools/metrics/histograms/histograms.xml:24226: + <int value="1" label="HasClient"/> nit: nit: ...
7 years, 3 months ago (2013-09-16 18:56:49 UTC) #2
Philippe
Thanks Ilya! https://codereview.chromium.org/24125004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/24125004/diff/1/tools/metrics/histograms/histograms.xml#newcode24226 tools/metrics/histograms/histograms.xml:24226: + <int value="1" label="HasClient"/> On 2013/09/16 18:56:49, ...
7 years, 3 months ago (2013-09-17 08:45:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/24125004/4001
7 years, 3 months ago (2013-09-17 08:45:24 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79703
7 years, 3 months ago (2013-09-17 14:36:08 UTC) #5
Philippe
7 years, 3 months ago (2013-09-17 15:17:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r223617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698