Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2412493003: Revert of Move ENABLE_PEPPER_CDMS to a buildflag header. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
jrummell, jschuh, brettw, ddorwin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, msramek+watch_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, droger+watchlist_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, raymes+watch_chromium.org, Dirk Pranke, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, agrieve+watch_chromium.org, tfarina, markusheintz_, android-webview-reviews_chromium.org, miu+watch_chromium.org, ddorwin, xhwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move ENABLE_PEPPER_CDMS to a buildflag header. (patchset #5 id:80001 of https://codereview.chromium.org/2411433002/ ) Reason for revert: Broke build https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/14706 Original issue's description: > Move ENABLE_PEPPER_CDMS to a buildflag header. > > Removes the global build flag and #define and converts to a buildflag header in > ppapi/features. > > A new target "//third_party/widevine/cdm:headers" was added since > widevine_cdm_version.h was unreferenced in the build. Given that this file now > requires //ppapi/features we really need "gn check" to work on it. I made the > existing users of ":version_h" reference this new target which encompasses the > public headers of the widevine CDM. > > TBR=jschuh (render_messages.h) > > Committed: https://crrev.com/e23a62a0c4b56618da615698717ed53983854f8d > Cr-Commit-Position: refs/heads/master@{#424477} TBR=jrummell@chromium.org,ddorwin@chromium.org,jschuh@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2d7d8a5e77ba0ee8c4c0e03a2ac4b15977926ca6 Cr-Commit-Position: refs/heads/master@{#424507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -233 lines) Patch
M android_webview/renderer/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/features.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 8 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/load_library_perf_test.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 9 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 12 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 6 chunks +5 lines, -6 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/chrome_paths.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/renderer/pepper/pepper_uma_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_uma_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +2 lines, -5 lines 0 comments Download
M chromecast/media/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cdm/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/cdm/renderer/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/cdm/renderer/external_clear_key_key_system_properties.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/cdm/renderer/external_clear_key_key_system_properties.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/cdm/renderer/widevine_key_system_properties.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/cdm/renderer/widevine_key_system_properties.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 3 chunks +1 line, -3 lines 0 comments Download
M content/renderer/media/cdm/pepper_cdm_wrapper.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/cdm/pepper_cdm_wrapper_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/cdm/pepper_cdm_wrapper_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/cdm/render_cdm_factory.h View 3 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/media/cdm/render_cdm_factory.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 3 chunks +2 lines, -4 lines 0 comments Download
M media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/BUILD.gn View 3 chunks +2 lines, -5 lines 0 comments Download
M media/base/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/key_system_properties.cc View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/key_systems.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/base/key_systems.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M media/base/key_systems_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M media/blink/BUILD.gn View 2 chunks +17 lines, -18 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D ppapi/features/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D ppapi/features/features.gni View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 3 chunks +0 lines, -13 lines 0 comments Download
D third_party/widevine/cdm/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/widevine/cdm/widevine_cdm_common.h View 3 chunks +2 lines, -4 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
alph
Created Revert of Move ENABLE_PEPPER_CDMS to a buildflag header.
4 years, 2 months ago (2016-10-11 19:12:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412493003/1
4 years, 2 months ago (2016-10-11 19:13:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 19:14:48 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:18:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d7d8a5e77ba0ee8c4c0e03a2ac4b15977926ca6
Cr-Commit-Position: refs/heads/master@{#424507}

Powered by Google App Engine
This is Rietveld 408576698