Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2412483007:
Download and show artwork in MediaMetdata in media notification (Closed)
|
Created:
4 years, 2 months ago by Zhiqiang Zhang (Slow) Modified:
4 years, 2 months ago CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDownload and show artwork in MediaMetdata in media notification
In this CL, when the page sets MediaMetadata with artwork,
MediaSessionTabHelper will select one image to download and show it in
the media notification.
Test page:
https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html
BUG=616411
TEST=MANUAL
Committed: https://crrev.com/9d5532918decdbf695c5fe34bef3d2508ba970bc
Cr-Commit-Position: refs/heads/master@{#425450}
Patch Set 1 #
Total comments: 34
Patch Set 2 : Addressed Anton's comments #Patch Set 3 : rebased and nit #Patch Set 4 : Thanks to FindBugs, fixed some stupid bugs #
Messages
Total messages: 22 (12 generated)
zqzhang@chromium.org changed reviewers: + avayvod@chromium.org, mlamouri@chromium.org
Description was changed from ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. BUG=616411 ========== to ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 ==========
Description was changed from ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 ========== to ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 ==========
Some initial thoughts, I'll finish the review tomorrow. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:23: // The default score of unknown image size. how were these constants for scores determined? what's the idea behind the scores? should it be in a comment above the class maybe? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:35: final int mMinimumSize; nit: initialize with the rest of the members (or don't initialize any since Java initializes everything). https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:114: mCallback.onImageDownloaded(bestBitmap); nit: one liner? do you want to report a failure too? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:142: double newScore = getImageSizeScore(size); nit: unused https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:150: int dominantSize = Math.max(size.width(), size.height()); should we prefer square images to super-wide or super-high? maybe pick an average or min from width and height? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:158: return 0.4 + 0.4 * (dominantSize - mMinimumSize) / (mIdealSize - mMinimumSize); you subtract minimum size here but not below? why? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:160: // Larger images has high preference. The score lies in [0.6, 1.0]. so [0.4, 0.8] vs [0.6, 1.0]? the image of ideal size will get a score of 1.8 actually (I think you need to divide by 4 * mIdealSize below) if I'm correct, once fixed, it will get 0.9 twice ideal size will get 0.8, ideal size - 1 pixel will also get 0.8. do we want to compare them the same way? the score calculation is quite confusing :/ https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:162: return 0.6 + 0.4 * (4 * mIdealSize - dominantSize) / mIdealSize; sounds like what you want is: if (min_image_size < min_preferred_size) return 0; if (min_image_size > max_preferred_size [=ideal size * 4]) return 0; // do we care much about comparing those by giving them a score? if (min_image_size < ideal_size) { divider = ideal_size - min_preferred_size; // can't be 0, right? return (ideal_size - min_image_size) / divider; } else if (min_image_size > ideal_size) { divider = max_preferred_size - ideal_size; return (min_image_size - ideal_size) / divider; } else { return 1; } https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:164: // Images that are too large is not prefered. The score lies in [0, 0.4]. nit: "Very large images are not preferred." https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:165: return 0.4 * dominantSize / mIdealSize / 4; nit: use () to make the order of operation clearer for the reader https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:168: private double getTypeScore(String url, String type) { nit:getImageTypeScore to be consistent with size? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:169: if (url.endsWith("png") || TextUtils.equals("image/png", type)) return TYPE_SCORE_PNG; nit: sounds like a good candidate for a static map from a url/type pair to the score? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:385: if (isRunningN()) { maybe set icons_size_dp to one of the values and then have one return statement?
And I finished my review :) https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java:201: mFallbackTitle = ""; hm, why is this change here? is that a follow up to the metadata update change?
Thanks for the review. PTAL :) https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:23: // The default score of unknown image size. On 2016/10/13 23:16:55, whywhat wrote: > how were these constants for scores determined? what's the idea behind the > scores? > should it be in a comment above the class maybe? Done. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:35: final int mMinimumSize; On 2016/10/13 23:16:55, whywhat wrote: > nit: initialize with the rest of the members (or don't initialize any since Java > initializes everything). Done. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:114: mCallback.onImageDownloaded(bestBitmap); On 2016/10/13 23:16:55, whywhat wrote: > nit: one liner? > do you want to report a failure too? Done. We don't have a strong need for failure report for now. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:142: double newScore = getImageSizeScore(size); On 2016/10/13 23:16:54, whywhat wrote: > nit: unused Removed. Didn't change to one-liner style since putting an assignment in a one-liner looks weird. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:150: int dominantSize = Math.max(size.width(), size.height()); On 2016/10/13 23:16:55, whywhat wrote: > should we prefer square images to super-wide or super-high? maybe pick an > average or min from width and height? I think the page should make sure the images have the same aspect ratio. We currently scale the image to a square one so they may look stretched. I think we can fine-tune later since this also needs to modify MediaNotificationManager. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:158: return 0.4 + 0.4 * (dominantSize - mMinimumSize) / (mIdealSize - mMinimumSize); On 2016/10/13 23:16:55, whywhat wrote: > you subtract minimum size here but not below? why? Won't change since I'm using a new logic. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:160: // Larger images has high preference. The score lies in [0.6, 1.0]. On 2016/10/13 23:16:55, whywhat wrote: > so [0.4, 0.8] vs [0.6, 1.0]? > > the image of ideal size will get a score of 1.8 actually (I think you need to > divide by 4 * mIdealSize below) > if I'm correct, once fixed, it will get 0.9 > twice ideal size will get 0.8, > ideal size - 1 pixel will also get 0.8. > do we want to compare them the same way? > the score calculation is quite confusing :/ Won't change since I'm using a new logic. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:162: return 0.6 + 0.4 * (4 * mIdealSize - dominantSize) / mIdealSize; On 2016/10/13 23:16:54, whywhat wrote: > sounds like what you want is: > > if (min_image_size < min_preferred_size) return 0; > if (min_image_size > max_preferred_size [=ideal size * 4]) return 0; // do we > care much about comparing those by giving them a score? > > if (min_image_size < ideal_size) { > divider = ideal_size - min_preferred_size; // can't be 0, right? > return (ideal_size - min_image_size) / divider; > } else if (min_image_size > ideal_size) { > divider = max_preferred_size - ideal_size; > return (min_image_size - ideal_size) / divider; > } else { > return 1; > } Hmm, seems you are right. The score should be a continuous function. I thought mIdealSize+1 should be better than mIdealSize-1, but actually they are both blurry. Fixed this in the new revision. Besides accepting your suggestion, I think we should have: * 0.2 at mMinimumSize, since we don't want a 0. * something around 0.6 at 4*mIdealSize since it must be better than mMinimumSize. Or maybe we should set the lower bound even higher? BTW, do you think 4*mIdealSize is a good upper bound? not very sure about this, since it may vary depending on screen density. Then a 1024x1024 picture may work on a good screen but will be discarded for a low-end device. Maybe we should have a device-independent upper bound? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:164: // Images that are too large is not prefered. The score lies in [0, 0.4]. On 2016/10/13 23:16:54, whywhat wrote: > nit: "Very large images are not preferred." Won't fix since I'm using the new logic. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:165: return 0.4 * dominantSize / mIdealSize / 4; On 2016/10/13 23:16:55, whywhat wrote: > nit: use () to make the order of operation clearer for the reader Done. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:168: private double getTypeScore(String url, String type) { On 2016/10/13 23:16:55, whywhat wrote: > nit:getImageTypeScore to be consistent with size? Not sure, I think we can just keep type score reasonably distributed, since it's multiplied with size score, not plus. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:169: if (url.endsWith("png") || TextUtils.equals("image/png", type)) return TYPE_SCORE_PNG; On 2016/10/13 23:16:55, whywhat wrote: > nit: sounds like a good candidate for a static map from a url/type pair to the > score? Done. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:385: if (isRunningN()) { On 2016/10/13 23:16:55, whywhat wrote: > maybe set icons_size_dp to one of the values and then have one return statement? Done. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java:201: mFallbackTitle = ""; On 2016/10/14 14:19:59, whywhat wrote: > hm, why is this change here? is that a follow up to the metadata update change? Yes, Moved this to a seperate CL, since it's irrelevant in this one.
Description was changed from ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 ========== to ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 TEST=MANUAL ==========
https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:168: private double getTypeScore(String url, String type) { On 2016/10/14 at 15:11:50, Zhiqiang Zhang wrote: > On 2016/10/13 23:16:55, whywhat wrote: > > nit:getImageTypeScore to be consistent with size? > > Not sure, I think we can just keep type score reasonably distributed, since it's multiplied with size score, not plus. I meant the naming to be consistent :) getImageTypeScore getImageSizeScore.
lgtm https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:150: int dominantSize = Math.max(size.width(), size.height()); On 2016/10/14 at 15:11:50, Zhiqiang Zhang wrote: > On 2016/10/13 23:16:55, whywhat wrote: > > should we prefer square images to super-wide or super-high? maybe pick an > > average or min from width and height? > > I think the page should make sure the images have the same aspect ratio. > > We currently scale the image to a square one so they may look stretched. > I think we can fine-tune later since this also needs to modify MediaNotificationManager. Well, we could crop the centered square or we could just ignore non-square images? That would help with scoring though (perhaps we should penalize images we cropped vs square ones). Or just penalize non-square images for now? https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:162: return 0.6 + 0.4 * (4 * mIdealSize - dominantSize) / mIdealSize; On 2016/10/14 at 15:11:50, Zhiqiang Zhang wrote: > On 2016/10/13 23:16:54, whywhat wrote: > > sounds like what you want is: > > > > if (min_image_size < min_preferred_size) return 0; > > if (min_image_size > max_preferred_size [=ideal size * 4]) return 0; // do we > > care much about comparing those by giving them a score? > > > > if (min_image_size < ideal_size) { > > divider = ideal_size - min_preferred_size; // can't be 0, right? > > return (ideal_size - min_image_size) / divider; > > } else if (min_image_size > ideal_size) { > > divider = max_preferred_size - ideal_size; > > return (min_image_size - ideal_size) / divider; > > } else { > > return 1; > > } > > Hmm, seems you are right. The score should be a continuous function. > I thought mIdealSize+1 should be better than mIdealSize-1, but actually they are both blurry. > > Fixed this in the new revision. > > Besides accepting your suggestion, I think we should have: > * 0.2 at mMinimumSize, since we don't want a 0. > * something around 0.6 at 4*mIdealSize since it must be better than mMinimumSize. > Or maybe we should set the lower bound even higher? > > BTW, do you think 4*mIdealSize is a good upper bound? not very sure about this, since it may vary depending on screen density. Then a 1024x1024 picture may work on a good screen but will be discarded for a low-end device. Maybe we should have a device-independent upper bound? I'm not sure about this either :) Do you have examples of various sizes on various devices with screenshots how they look? That could help make a good decision.
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java (right): https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:150: int dominantSize = Math.max(size.width(), size.height()); On 2016/10/14 15:30:33, whywhat wrote: > On 2016/10/14 at 15:11:50, Zhiqiang Zhang wrote: > > On 2016/10/13 23:16:55, whywhat wrote: > > > should we prefer square images to super-wide or super-high? maybe pick an > > > average or min from width and height? > > > > I think the page should make sure the images have the same aspect ratio. > > > > We currently scale the image to a square one so they may look stretched. > > I think we can fine-tune later since this also needs to modify > MediaNotificationManager. > > Well, we could crop the centered square or we could just ignore non-square > images? That would help with scoring though (perhaps we should penalize images > we cropped vs square ones). Or just penalize non-square images for now? Filed https://crbug.com/656028, let's discuss there. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:162: return 0.6 + 0.4 * (4 * mIdealSize - dominantSize) / mIdealSize; On 2016/10/14 15:30:33, whywhat wrote: > On 2016/10/14 at 15:11:50, Zhiqiang Zhang wrote: > > On 2016/10/13 23:16:54, whywhat wrote: > > > sounds like what you want is: > > > > > > if (min_image_size < min_preferred_size) return 0; > > > if (min_image_size > max_preferred_size [=ideal size * 4]) return 0; // do > we > > > care much about comparing those by giving them a score? > > > > > > if (min_image_size < ideal_size) { > > > divider = ideal_size - min_preferred_size; // can't be 0, right? > > > return (ideal_size - min_image_size) / divider; > > > } else if (min_image_size > ideal_size) { > > > divider = max_preferred_size - ideal_size; > > > return (min_image_size - ideal_size) / divider; > > > } else { > > > return 1; > > > } > > > > Hmm, seems you are right. The score should be a continuous function. > > I thought mIdealSize+1 should be better than mIdealSize-1, but actually they > are both blurry. > > > > Fixed this in the new revision. > > > > Besides accepting your suggestion, I think we should have: > > * 0.2 at mMinimumSize, since we don't want a 0. > > * something around 0.6 at 4*mIdealSize since it must be better than > mMinimumSize. > > Or maybe we should set the lower bound even higher? > > > > BTW, do you think 4*mIdealSize is a good upper bound? not very sure about > this, since it may vary depending on screen density. Then a 1024x1024 picture > may work on a good screen but will be discarded for a low-end device. Maybe we > should have a device-independent upper bound? > > I'm not sure about this either :) Do you have examples of various sizes on > various devices with screenshots how they look? That could help make a good > decision. Filed https://crbug.com/656028, let's discuss there. https://codereview.chromium.org/2412483007/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java:168: private double getTypeScore(String url, String type) { On 2016/10/14 15:24:20, whywhat wrote: > On 2016/10/14 at 15:11:50, Zhiqiang Zhang wrote: > > On 2016/10/13 23:16:55, whywhat wrote: > > > nit:getImageTypeScore to be consistent with size? > > > > Not sure, I think we can just keep type score reasonably distributed, since > it's multiplied with size score, not plus. > > I meant the naming to be consistent :) > getImageTypeScore > getImageSizeScore. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by zqzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org Link to the patchset: https://codereview.chromium.org/2412483007/#ps60001 (title: "Thanks to FindBugs, fixed some stupid bugs")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 TEST=MANUAL ========== to ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 TEST=MANUAL ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 TEST=MANUAL ========== to ========== Download and show artwork in MediaMetdata in media notification In this CL, when the page sets MediaMetadata with artwork, MediaSessionTabHelper will select one image to download and show it in the media notification. Test page: https://xxyzzzq.github.io/sandbox/media-session/test-multiple-icons.html BUG=616411 TEST=MANUAL Committed: https://crrev.com/9d5532918decdbf695c5fe34bef3d2508ba970bc Cr-Commit-Position: refs/heads/master@{#425450} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9d5532918decdbf695c5fe34bef3d2508ba970bc Cr-Commit-Position: refs/heads/master@{#425450} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
