Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2412483006: Reduce code duplication in CPDF_Type1Font::LoadGlyphMap (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Reduce code duplication in CPDF_Type1Font::LoadGlyphMap Added methods SetExtGID and CalcExtGID for this purpose. Changed protected to private: no one inherits CPDF_Type1Font. Committed: https://pdfium.googlesource.com/pdfium/+/7cc6a32693a07210e036a8d7131232231ec0fdb3

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -84 lines) Patch
M core/fpdfapi/font/cpdf_type1font.h View 1 chunk +6 lines, -1 line 0 comments Download
M core/fpdfapi/font/cpdf_type1font.cpp View 1 6 chunks +27 lines, -83 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
npm
PTAL
4 years, 2 months ago (2016-10-12 18:21:14 UTC) #7
dsinclair
lgtm
4 years, 2 months ago (2016-10-12 18:37:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412483006/20001
4 years, 2 months ago (2016-10-12 18:37:56 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 18:38:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7cc6a32693a07210e036a8d7131232231ec0...

Powered by Google App Engine
This is Rietveld 408576698