Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2412483005: Restore kDeclaration as a condition for temp-zone parsing (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restore kDeclaration as a condition for temp-zone parsing This should restore the codeload regression when FLAG_lazy_inner_functions is turned off BUG=v8:5501 Committed: https://crrev.com/c5df7fe2f3b5bd4182fe0b51c849cb6c35aadb6b Cr-Commit-Position: refs/heads/master@{#40217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/parsing/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-12 09:36:43 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-12 11:48:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412483005/1
4 years, 2 months ago (2016-10-12 12:12:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 12:53:29 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 12:53:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5df7fe2f3b5bd4182fe0b51c849cb6c35aadb6b
Cr-Commit-Position: refs/heads/master@{#40217}

Powered by Google App Engine
This is Rietveld 408576698