Add support for patching class methods.

Add support for patching class methods.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/cbb898bca74b38859f1c0f2e49d1beec6fbd9509

[Brian Wilkerson, 2016-10-13 18:49:40]

lgtm

[scheglov, 2016-10-13 18:55:58]

Description was changed from

==========
Add support for patching class methods.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add support for patching class methods.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/cbb898bca74b38859f1c0f2e49d1beec6fbd9509
==========

[scheglov, 2016-10-13 18:55:59]

Committed patchset #1 (id:1) manually as
cbb898bca74b38859f1c0f2e49d1beec6fbd9509 (presubmit successful).

[Paul Berry, 2016-10-13 19:09:52]

lgtm

https://codereview.chromium.org/2412453007/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/patch.dart (right):

https://codereview.chromium.org/2412453007/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:111: // Remove the "external" keyword.
It looks like we have some duplication between this code and the code in
_patchTopLevelDeclarations (everything between here and "baseMember.body =
newBody").  How about extracting a method to share code?

https://codereview.chromium.org/2412453007/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:141:
newMember.endToken.setNext(lastToken.next);
Consider extracting a method for this logic too.

[scheglov, 2016-10-13 20:18:14]

https://codereview.chromium.org/2412453007/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/patch.dart (right):

https://codereview.chromium.org/2412453007/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:111: // Remove the "external" keyword.
On 2016/10/13 19:09:52, Paul Berry wrote:
> It looks like we have some duplication between this code and the code in
> _patchTopLevelDeclarations (everything between here and "baseMember.body =
> newBody").  How about extracting a method to share code?

It does not seem practical to me.
Both "externalKeyword" getter and setter are defined in leaf classes
FunctionDeclaration and MethodDeclaration. And there is not much code to share.
Well, we could use callback, but...

https://codereview.chromium.org/2412453007/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:141:
newMember.endToken.setNext(lastToken.next);
On 2016/10/13 19:09:52, Paul Berry wrote:
> Consider extracting a method for this logic too.

OK
https://codereview.chromium.org/2417053002