Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: src/ic/ic-state.h

Issue 2412453005: [stubs] Refactor the CallICStub to pass the number of arguments. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/interface-descriptors-ia32.cc ('k') | src/ic/ic-state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic-state.h
diff --git a/src/ic/ic-state.h b/src/ic/ic-state.h
index 38be57ac04f196fadc1410d057a12baf718d9539..1ba37b99dbfd4d7e722452fde28475a3d58a5480 100644
--- a/src/ic/ic-state.h
+++ b/src/ic/ic-state.h
@@ -26,10 +26,8 @@ class CallICState final BASE_EMBEDDED {
public:
explicit CallICState(ExtraICState extra_ic_state)
: bit_field_(extra_ic_state) {}
- CallICState(int argc, ConvertReceiverMode convert_mode,
- TailCallMode tail_call_mode)
- : bit_field_(ArgcBits::encode(argc) |
- ConvertModeBits::encode(convert_mode) |
+ CallICState(ConvertReceiverMode convert_mode, TailCallMode tail_call_mode)
+ : bit_field_(ConvertModeBits::encode(convert_mode) |
TailCallModeBits::encode(tail_call_mode)) {}
ExtraICState GetExtraICState() const { return bit_field_; }
@@ -38,7 +36,6 @@ class CallICState final BASE_EMBEDDED {
void (*Generate)(Isolate*,
const CallICState&));
- int argc() const { return ArgcBits::decode(bit_field_); }
ConvertReceiverMode convert_mode() const {
return ConvertModeBits::decode(bit_field_);
}
@@ -47,8 +44,7 @@ class CallICState final BASE_EMBEDDED {
}
private:
- typedef BitField<int, 0, Code::kArgumentsBits> ArgcBits;
- typedef BitField<ConvertReceiverMode, ArgcBits::kNext, 2> ConvertModeBits;
+ typedef BitField<ConvertReceiverMode, 0, 2> ConvertModeBits;
typedef BitField<TailCallMode, ConvertModeBits::kNext, 1> TailCallModeBits;
int const bit_field_;
« no previous file with comments | « src/ia32/interface-descriptors-ia32.cc ('k') | src/ic/ic-state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698