Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2412453005: [stubs] Refactor the CallICStub to pass the number of arguments. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Refactor the CallICStub to pass the number of arguments. This is the next step to unify the Call/Construct feedback collection and prepare it to be able to collect SharedFunctionInfo feedback. This also reduces the CallICStub overhead quite a bit since we only need one stub per mode (and tail call mode), not also one per call arity. R=mvstanton@chromium.org BUG=v8:2206 NOTRY=true Committed: https://crrev.com/c15c58274f04eef9d62245f33a836cd8287b9c53 Cr-Commit-Position: refs/heads/master@{#40206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -89 lines) Patch
M src/arm/code-stubs-arm.cc View 6 chunks +15 lines, -12 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 8 chunks +15 lines, -6 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/code-factory.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 9 chunks +15 lines, -5 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-state.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/ic/ic-state.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 7 chunks +16 lines, -9 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 7 chunks +16 lines, -9 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 8 chunks +13 lines, -6 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-12 05:50:39 UTC) #1
Benedikt Meurer
Hey Michael, Next step in CallIC business. Please take a look. Thanks, Benedikt
4 years, 2 months ago (2016-10-12 06:34:00 UTC) #4
mvstanton
lgtm
4 years, 2 months ago (2016-10-12 09:23:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412453005/1
4 years, 2 months ago (2016-10-12 09:23:36 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 09:25:59 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 09:26:26 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c15c58274f04eef9d62245f33a836cd8287b9c53
Cr-Commit-Position: refs/heads/master@{#40206}

Powered by Google App Engine
This is Rietveld 408576698