Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2412453003: [heap] RemoveRange of SlotSet should not push nullptr for empty buckets on the pre-free stack. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] RemoveRange of SlotSet should not push nullptr for empty buckets on the pre-free stack. BUG=chromium:648568 Committed: https://crrev.com/da8654dba086c13a77fae33ed7829c39789ccba5 Cr-Commit-Position: refs/heads/master@{#40176}

Patch Set 1 #

Patch Set 2 : move mutex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/heap/slot-set.h View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ulan
lgtm
4 years, 2 months ago (2016-10-11 14:10:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412453003/20001
4 years, 2 months ago (2016-10-11 14:11:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-11 14:41:48 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 14:42:16 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da8654dba086c13a77fae33ed7829c39789ccba5
Cr-Commit-Position: refs/heads/master@{#40176}

Powered by Google App Engine
This is Rietveld 408576698