Recalculate |visiblePos| for InsertParagraphSeparatorCommand::doApply() after mutations

Recalculate |visiblePos| for InsertParagraphSeparatorCommand::doApply() after mutations

This patch does the following change to the above mentioned function that,
|visiblePos| is always recalculated as |createVisiblePosition(insertionPosition)|
before being used, so that it is always valid at those places.

BUG=648949
Committed: https://crrev.com/7850cba844bb06053c9d6d553700240d15978af4
Cr-Commit-Position: refs/heads/master@{#424673}

[Xiaocheng, 2016-10-11 07:47:47]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 07:47:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-11 08:49:34]

Description was changed from

==========
Recalculate |visiblePos| for InsertParagraphCommand::doApply() after mutations

BUG=648949
==========

to

==========
Recalculate |visiblePos| for InsertParagraphSeparatorCommand::doApply() after
mutations

This patch does the following change to the above mentioned function that,
|visiblePos| is always recalculated as
|createVisiblePosition(insertionPosition)|
before being used, so that it is always valid at those places.

BUG=648949
==========

[Xiaocheng, 2016-10-11 09:20:36]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-11 09:20:37]

PTAL.

[commit-bot: I haz the power, 2016-10-11 09:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 09:23:13]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-12 04:48:56]

lgtm

Can we use separate variable name for each life span of |visiblePos|?

[Xiaocheng, 2016-10-12 04:52:56]

On 2016/10/12 at 04:48:56, yosin wrote:
> lgtm
> 
> Can we use separate variable name for each life span of |visiblePos|?

Sounds like a principle that should be enforced when we try to eliminate all
current usages of invalid VPs.

I'll put it in crbug.com/648949 and land this patch for now.

[Xiaocheng, 2016-10-12 04:53:01]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-10-12 04:53:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 05:03:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 05:03:03]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-10-12 05:04:33]

Description was changed from

==========
Recalculate |visiblePos| for InsertParagraphSeparatorCommand::doApply() after
mutations

This patch does the following change to the above mentioned function that,
|visiblePos| is always recalculated as
|createVisiblePosition(insertionPosition)|
before being used, so that it is always valid at those places.

BUG=648949
==========

to

==========
Recalculate |visiblePos| for InsertParagraphSeparatorCommand::doApply() after
mutations

This patch does the following change to the above mentioned function that,
|visiblePos| is always recalculated as
|createVisiblePosition(insertionPosition)|
before being used, so that it is always valid at those places.

BUG=648949

Committed: https://crrev.com/7850cba844bb06053c9d6d553700240d15978af4
Cr-Commit-Position: refs/heads/master@{#424673}
==========

[commit-bot: I haz the power, 2016-10-12 05:04:34]

Patchset 1 (id:??) landed as
https://crrev.com/7850cba844bb06053c9d6d553700240d15978af4
Cr-Commit-Position: refs/heads/master@{#424673}