Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 2412423003: Punt touch UGI deprecation to M56 (Closed)

Created:
4 years, 2 months ago by Rick Byers
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, Raymond Toy, foolip
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Punt touch UGI deprecation to M56 BUG=654978 Review-Url: https://codereview.chromium.org/2408203004 Cr-Commit-Position: refs/heads/master@{#424739} (cherry picked from commit 5228ba9c95482de8e3615f189bcf822806e99010) Committed: https://chromium.googlesource.com/chromium/src/+/33d95c3c0e29e1263bd81aacbbaa15906abdd278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/touch-user-gesture-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Rick Byers
Committed patchset #1 (id:1) manually as 33d95c3c0e29e1263bd81aacbbaa15906abdd278.
4 years, 2 months ago (2016-10-13 18:57:13 UTC) #2
johnme
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2419563004/ by johnme@chromium.org. ...
4 years, 2 months ago (2016-10-14 14:09:40 UTC) #3
Rick Byers
4 years, 2 months ago (2016-10-14 16:12:12 UTC) #5
Message was sent while issue was closed.
On 2016/10/14 14:09:40, johnme wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2419563004/ by mailto:johnme@chromium.org.
> 
> The reason for reverting is: This patch breaks compile on the branch, since
the
> "M55" enum value is still used with dopplerWillBeRemoved (note that
>
https://chromium.googlesource.com/chromium/src/+/9848564877f0057f4dcbc98bce06...
> removes dopplerWillBeRemoved on master, but that patch is not on the branch).

Ah damn, sorry.  I should have verified that there weren't other users of M55 on
the branch.  I'll do a partial merge.

But we shouldn't be saying in 55 that something "will be removed" in 55 - that's
just confusing.  Filed
https://bugs.chromium.org/p/chromium/issues/detail?id=656030 for rtoy@

Powered by Google App Engine
This is Rietveld 408576698