[turbofan] Native-context-spec: Use the CheckMaps for polymorphic fall-through.

src/compiler/js-native-context-specialization.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/js-native-context-specialization.h"
 
 #include "src/accessors.h"
 #include "src/code-factory.h"
 #include "src/compilation-dependencies.h"
 #include "src/compiler/access-builder.h"
@@ skipping 197 matching lines @@
         graph()->NewNode(simplified()->LoadField(AccessBuilder::ForMap()),
                          receiver, effect, control);
 
     // Generate code for the various different property access patterns.
     Node* fallthrough_control = control;
     for (size_t j = 0; j < access_infos.size(); ++j) {
       PropertyAccessInfo const& access_info = access_infos[j];
       Node* this_value = value;
       Node* this_receiver = receiver;
       Node* this_effect = effect;
-      Node* this_control;
+      Node* this_control = fallthrough_control;
 
       // Perform map check on {receiver}.
       MapList const& receiver_maps = access_info.receiver_maps();
       {
         // Emit a (sequence of) map checks for other {receiver}s.
         ZoneVector<Node*> this_controls(zone());
         ZoneVector<Node*> this_effects(zone());
-        size_t num_classes = receiver_maps.size();
-        for (auto map : receiver_maps) {
-          DCHECK_LT(0u, num_classes);
-          Node* check =
-              graph()->NewNode(simplified()->ReferenceEqual(), receiver_map,
-                               jsgraph()->Constant(map));
-          if (--num_classes == 0 && j == access_infos.size() - 1) {
-            check = graph()->NewNode(simplified()->CheckIf(), check,
-                                     this_effect, fallthrough_control);
-            this_controls.push_back(fallthrough_control);
-            this_effects.push_back(check);
-            fallthrough_control = nullptr;
-          } else {
+        if (j == access_infos.size() - 1) {
+          // Last map check on the fallthrough control path, do a
+          // conditional eager deoptimization exit here.
+          this_effect = BuildCheckMaps(receiver, this_effect, this_control,
+                                       receiver_maps);
+          this_effects.push_back(this_effect);
+          this_controls.push_back(fallthrough_control);
+          fallthrough_control = nullptr;
+        } else {
+          for (auto map : receiver_maps) {
+            Node* check =
+                graph()->NewNode(simplified()->ReferenceEqual(), receiver_map,
+                                 jsgraph()->Constant(map));
             Node* branch = graph()->NewNode(common()->Branch(), check,
                                             fallthrough_control);
             fallthrough_control = graph()->NewNode(common()->IfFalse(), branch);
             this_controls.push_back(
                 graph()->NewNode(common()->IfTrue(), branch));
             this_effects.push_back(this_effect);
           }
         }
 
         // The Number case requires special treatment to also deal with Smis.
@@ skipping 323 matching lines @@
               this_control);
         }
 
         // Load the {receiver} map.
         Node* receiver_map = this_effect =
             graph()->NewNode(simplified()->LoadField(AccessBuilder::ForMap()),
                              receiver, this_effect, this_control);
 
         // Perform map check(s) on {receiver}.
         MapList const& receiver_maps = access_info.receiver_maps();
-        {
+        if (j == access_infos.size() - 1) {
+          // Last map check on the fallthrough control path, do a
+          // conditional eager deoptimization exit here.
+          this_effect = BuildCheckMaps(receiver, this_effect, this_control,
+                                       receiver_maps);
+          fallthrough_control = nullptr;
+        } else {
           ZoneVector<Node*> this_controls(zone());
           ZoneVector<Node*> this_effects(zone());
-          size_t num_classes = receiver_maps.size();
           for (Handle<Map> map : receiver_maps) {
-            DCHECK_LT(0u, num_classes);
             Node* check =
                 graph()->NewNode(simplified()->ReferenceEqual(), receiver_map,
                                  jsgraph()->Constant(map));
-            if (--num_classes == 0 && j == access_infos.size() - 1) {
-              // Last map check on the fallthrough control path, do a
-              // conditional eager deoptimization exit here.
-              // TODO(turbofan): This is ugly as hell! We should probably
-              // introduce macro-ish operators for property access that
-              // encapsulate this whole mess.
-              check = graph()->NewNode(simplified()->CheckIf(), check,
-                                       this_effect, this_control);
-              this_controls.push_back(this_control);
-              this_effects.push_back(check);
-              fallthrough_control = nullptr;
-            } else {
-              Node* branch = graph()->NewNode(common()->Branch(), check,
-                                              fallthrough_control);
-              this_controls.push_back(
-                  graph()->NewNode(common()->IfTrue(), branch));
-              this_effects.push_back(this_effect);
-              fallthrough_control =
-                  graph()->NewNode(common()->IfFalse(), branch);
-            }
+            Node* branch = graph()->NewNode(common()->Branch(), check,
+                                            fallthrough_control);
+            this_controls.push_back(
+                graph()->NewNode(common()->IfTrue(), branch));
+            this_effects.push_back(this_effect);
+            fallthrough_control = graph()->NewNode(common()->IfFalse(), branch);
           }
 
           // Create single chokepoint for the control.
           int const this_control_count = static_cast<int>(this_controls.size());
           if (this_control_count == 1) {
             this_control = this_controls.front();
             this_effect = this_effects.front();
           } else {
             this_control =
                 graph()->NewNode(common()->Merge(this_control_count),
@@ skipping 882 matching lines @@
   return jsgraph()->javascript();
 }
 
 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const {
   return jsgraph()->simplified();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8