Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2412373002: Gzip compress IDR_AUDIO_SPATIALIZATION_COMPOSITE. (Closed)

Created:
4 years, 2 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 2 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gzip compress IDR_AUDIO_SPATIALIZATION_COMPOSITE. This WAV file is an HRTF database needed by WebAudio. It's the largest single resource in Resources.pak on Android. Applying gzip compression shrinks it from 240k to 140k (still the largest resource, even then). The tradeoff will be worse WebAudio startup time and RAM usage, but WebAudio is rarely used so it's more important to optimize for global cost on all users (in this case, APK size). BUG=655429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/public/blink_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
aelias_OOO_until_Jul13
Hi rtoy@, PTAL.
4 years, 2 months ago (2016-10-13 01:17:59 UTC) #3
agrieve
On 2016/10/13 01:17:59, aelias wrote: > Hi rtoy@, PTAL. I'd guess this breaks whatever the ...
4 years, 2 months ago (2016-10-13 01:34:24 UTC) #6
agrieve
On 2016/10/13 01:34:24, agrieve wrote: > On 2016/10/13 01:17:59, aelias wrote: > > Hi rtoy@, ...
4 years, 2 months ago (2016-10-13 01:38:32 UTC) #7
aelias_OOO_until_Jul13
4 years, 2 months ago (2016-10-13 02:12:32 UTC) #8
Yeah, this WAV file ends up in DecodeAudioFileData(), so if I'm reading things
correctly, we could replace this resource with any other FFMpeg-supported audio
codec (including Flac) and things would "just work".  That seems cleaner than
trying to make gzip work, so closing this.

Powered by Google App Engine
This is Rietveld 408576698