tools/metrics/histograms/histograms.xml - Issue 2412343003: Add TaskScheduler.NumTasksBeforeDetach.[worker pool name] histogram.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2412343003: Add TaskScheduler.NumTasksBeforeDetach.[worker pool name] histogram. (Closed)

Patch Set: self-review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index c38d839599ed3e0c43a57e9ee4192fcb9c4dedd7..3425e4910ed435e9b1444c1f310de13bda17090d 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -64325,6 +64325,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="TaskScheduler.NumTasksBeforeDetach" units="tasks">

+ <owner>fdoray@chromium.org</owner>

+ <owner>gab@chromium.org</owner>

+ <owner>robliao@chromium.org</owner>

+ <summary>

+ Number of tasks executed by a SchedulerWorker before it detached. Recorded

+ when the SchedulerWorker is woken up after detaching. A low value indicates

+ that SchedulerWorkers are detached too often.

robliao 2016/10/13 18:04:04 Nit: Another conclusion could be the rate of work

fdoray 2016/10/13 20:38:53 Done.

+ </summary>

+</histogram>

<owner>fdoray@chromium.org</owner>

<owner>gab@chromium.org</owner>

@@ -110082,6 +110093,7 @@ value.

label="Applies to the ForegroundFileIO worker pool."/>

<affected-histogram name="TaskScheduler.DetachDuration"/>

+ <affected-histogram name="TaskScheduler.NumTasksBeforeDetach"/>

<affected-histogram name="TaskScheduler.NumTasksBetweenWaits"/>

<affected-histogram name="TaskScheduler.TaskLatency"/>

</histogram_suffixes>