Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: ui/base/ime/input_method_ibus.cc

Issue 24123006: Remove SendFakeProcessKeyEvent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_ibus.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_ibus.cc
diff --git a/ui/base/ime/input_method_ibus.cc b/ui/base/ime/input_method_ibus.cc
index c5bdb0e624d166d56d946282a39bea53690661e7..2dcb017e5c6120164a21ecdf4bc28df992275cad 100644
--- a/ui/base/ime/input_method_ibus.cc
+++ b/ui/base/ime/input_method_ibus.cc
@@ -557,12 +557,6 @@ bool InputMethodIBus::HasInputMethodResult() const {
return result_text_.length() || composition_changed_;
}
-void InputMethodIBus::SendFakeProcessKeyEvent(bool pressed) const {
- DispatchFabricatedKeyEventPostIME(pressed ? ET_KEY_PRESSED : ET_KEY_RELEASED,
- VKEY_PROCESSKEY,
- 0);
-}
-
void InputMethodIBus::AbandonAllPendingKeyEvents() {
pending_key_events_.clear();
}
@@ -588,9 +582,7 @@ void InputMethodIBus::CommitText(const chromeos::IBusText& text) {
// If we are not handling key event, do not bother sending text result if the
// focused text input client does not support text input.
if (pending_key_events_.empty() && !IsTextInputTypeNone()) {
- SendFakeProcessKeyEvent(true);
GetTextInputClient()->InsertText(utf16_text);
- SendFakeProcessKeyEvent(false);
result_text_.clear();
}
}
@@ -662,9 +654,7 @@ void InputMethodIBus::UpdatePreeditText(const chromeos::IBusText& text,
// If we receive a composition text without pending key event, then we need to
// send it to the focused text input client directly.
if (pending_key_events_.empty()) {
- SendFakeProcessKeyEvent(true);
GetTextInputClient()->SetCompositionText(composition_);
- SendFakeProcessKeyEvent(false);
composition_changed_ = false;
composition_.Clear();
}
« no previous file with comments | « ui/base/ime/input_method_ibus.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698