Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 24123002: Merge 157245 "Fix threading races on ConvolverNode::m_reverb in ..." (Closed)

Created:
7 years, 3 months ago by haraken
Modified:
7 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Merge 157245 "Fix threading races on ConvolverNode::m_reverb in ..." > Fix threading races on ConvolverNode::m_reverb in ConvolverNode::latencyFrames() > > According to the crash report (https://cluster-fuzz.appspot.com/testcase?key=6515787040817152), > ConvolverNode::m_reverb races between ConvolverNode::latencyFrames() and ConvolverNode::setBuffer(). > This CL adds a proper lock for ConvolverNode::m_reverb. > > BUG=223962 > No tests because the crash depends on threading races and thus not reproducible. > > Review URL: https://chromiumcodereview.appspot.com/23514037 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/modules/webaudio/ConvolverNode.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
7 years, 3 months ago (2013-09-12 19:21:14 UTC) #1
haraken
7 years, 3 months ago (2013-09-12 19:21:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r157690.

Powered by Google App Engine
This is Rietveld 408576698