Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2412243002: [Media Router] Update toolbar icons to handle non-retina displays. (Closed)

Created:
4 years, 2 months ago by apacible
Modified:
4 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Update toolbar icons to handle non-retina displays. This change updates the .icon dimensions from 19 to 16. This fixes an issue on non-retina displays where the icon is automatically scaled down, which makes the icons appear blurry. When the dimension is 16, the size auto-scales up for retina displays without blurring the image. The new icons were produced by a designer, and skiafied using estade@'s skiafy tool. Some manual tweaking done to the error icon. BUG=611793 TEST=manual testing on osx (retina, non-retina), linux, windows for all four icons Committed: https://crrev.com/98acaca15019db2fae365cd186660ff8b9276ae0 Cr-Commit-Position: refs/heads/master@{#425350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -127 lines) Patch
M ui/gfx/vector_icons/media_router_active.icon View 1 chunk +45 lines, -33 lines 0 comments Download
M ui/gfx/vector_icons/media_router_error.icon View 1 chunk +43 lines, -31 lines 0 comments Download
M ui/gfx/vector_icons/media_router_idle.icon View 1 chunk +39 lines, -27 lines 0 comments Download
M ui/gfx/vector_icons/media_router_warning.icon View 1 chunk +49 lines, -36 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
apacible
PTAL, thanks!
4 years, 2 months ago (2016-10-12 20:37:58 UTC) #7
Evan Stade
lgtm
4 years, 2 months ago (2016-10-14 14:54:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412243002/1
4 years, 2 months ago (2016-10-14 15:39:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 16:33:50 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:37:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98acaca15019db2fae365cd186660ff8b9276ae0
Cr-Commit-Position: refs/heads/master@{#425350}

Powered by Google App Engine
This is Rietveld 408576698