Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: content/browser/frame_host/frame_tree.cc

Issue 241223002: Start using RenderFrameProxyHost objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moar fixes. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree.h" 5 #include "content/browser/frame_host/frame_tree.h"
6 6
7 #include <queue> 7 #include <queue>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 47
48 // Iterate over the FrameTree to reset any node affected by the loss of the 48 // Iterate over the FrameTree to reset any node affected by the loss of the
49 // given RenderViewHost's process. 49 // given RenderViewHost's process.
50 bool ResetNodesForNewProcess(RenderViewHost* render_view_host, 50 bool ResetNodesForNewProcess(RenderViewHost* render_view_host,
51 FrameTreeNode* node) { 51 FrameTreeNode* node) {
52 if (render_view_host == node->current_frame_host()->render_view_host()) 52 if (render_view_host == node->current_frame_host()->render_view_host())
53 node->ResetForNewProcess(); 53 node->ResetForNewProcess();
54 return true; 54 return true;
55 } 55 }
56 56
57 bool CreateProxyForSiteInstance(FrameTreeNode* source_node,
58 const scoped_refptr<SiteInstance>& instance,
59 FrameTreeNode* node) {
60 // Skip the node that initiated the creation.
61 if (source_node == node)
62 return true;
63
64 node->render_manager()->CreateRenderFrameProxy(instance, MSG_ROUTING_NONE);
65 return true;
66 }
67
57 } // namespace 68 } // namespace
58 69
59 FrameTree::FrameTree(Navigator* navigator, 70 FrameTree::FrameTree(Navigator* navigator,
60 RenderFrameHostDelegate* render_frame_delegate, 71 RenderFrameHostDelegate* render_frame_delegate,
61 RenderViewHostDelegate* render_view_delegate, 72 RenderViewHostDelegate* render_view_delegate,
62 RenderWidgetHostDelegate* render_widget_delegate, 73 RenderWidgetHostDelegate* render_widget_delegate,
63 RenderFrameHostManager::Delegate* manager_delegate) 74 RenderFrameHostManager::Delegate* manager_delegate)
64 : render_frame_delegate_(render_frame_delegate), 75 : render_frame_delegate_(render_frame_delegate),
65 render_view_delegate_(render_view_delegate), 76 render_view_delegate_(render_view_delegate),
66 render_widget_delegate_(render_widget_delegate), 77 render_widget_delegate_(render_widget_delegate),
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 RenderFrameHostImpl* render_frame_host = child->current_frame_host(); 141 RenderFrameHostImpl* render_frame_host = child->current_frame_host();
131 if (!on_frame_removed_.is_null()) { 142 if (!on_frame_removed_.is_null()) {
132 on_frame_removed_.Run( 143 on_frame_removed_.Run(
133 render_frame_host->render_view_host(), 144 render_frame_host->render_view_host(),
134 render_frame_host->GetRoutingID()); 145 render_frame_host->GetRoutingID());
135 } 146 }
136 147
137 parent->RemoveChild(child); 148 parent->RemoveChild(child);
138 } 149 }
139 150
151 void FrameTree::CreateProxiesForSiteInstance(
152 FrameTreeNode* source,
153 const scoped_refptr<SiteInstance>& site_instance) {
154 ForEach(base::Bind(
155 &CreateProxyForSiteInstance, source, site_instance));
156 }
157
140 void FrameTree::ResetForMainFrameSwap() { 158 void FrameTree::ResetForMainFrameSwap() {
141 root_->ResetForNewProcess(); 159 root_->ResetForNewProcess();
142 focused_frame_tree_node_id_ = -1; 160 focused_frame_tree_node_id_ = -1;
143 } 161 }
144 162
145 void FrameTree::RenderProcessGone(RenderViewHost* render_view_host) { 163 void FrameTree::RenderProcessGone(RenderViewHost* render_view_host) {
146 // Walk the full tree looking for nodes that may be affected. Once a frame 164 // Walk the full tree looking for nodes that may be affected. Once a frame
147 // crashes, all of its child FrameTreeNodes go away. 165 // crashes, all of its child FrameTreeNodes go away.
148 // Note that the helper function may call ResetForNewProcess on a node, which 166 // Note that the helper function may call ResetForNewProcess on a node, which
149 // clears its children before we iterate over them. That's ok, because 167 // clears its children before we iterate over them. That's ok, because
(...skipping 12 matching lines...) Expand all
162 180
163 void FrameTree::SetFocusedFrame(FrameTreeNode* node) { 181 void FrameTree::SetFocusedFrame(FrameTreeNode* node) {
164 focused_frame_tree_node_id_ = node->frame_tree_node_id(); 182 focused_frame_tree_node_id_ = node->frame_tree_node_id();
165 } 183 }
166 184
167 void FrameTree::SetFrameRemoveListener( 185 void FrameTree::SetFrameRemoveListener(
168 const base::Callback<void(RenderViewHostImpl*, int)>& on_frame_removed) { 186 const base::Callback<void(RenderViewHostImpl*, int)>& on_frame_removed) {
169 on_frame_removed_ = on_frame_removed; 187 on_frame_removed_ = on_frame_removed;
170 } 188 }
171 189
172 RenderViewHostImpl* FrameTree::CreateRenderViewHostForMainFrame( 190 RenderViewHostImpl* FrameTree::CreateRenderViewHost(SiteInstance* site_instance,
173 SiteInstance* site_instance, 191 int routing_id,
174 int routing_id, 192 int main_frame_routing_id,
175 int main_frame_routing_id, 193 bool swapped_out,
176 bool swapped_out, 194 bool hidden) {
177 bool hidden) { 195 LOG(ERROR) << "FT::CreateRVHForMainFrame: "
196 << site_instance->GetSiteURL() << ":" << routing_id << ":"
197 << main_frame_routing_id << ", swapped_out: " << swapped_out;
178 DCHECK(main_frame_routing_id != MSG_ROUTING_NONE); 198 DCHECK(main_frame_routing_id != MSG_ROUTING_NONE);
179 RenderViewHostMap::iterator iter = 199 RenderViewHostMap::iterator iter =
180 render_view_host_map_.find(site_instance->GetId()); 200 render_view_host_map_.find(site_instance->GetId());
181 if (iter != render_view_host_map_.end()) { 201 if (iter != render_view_host_map_.end()) {
182 // If a RenderViewHost is pending shutdown for this |site_instance|, put it 202 // If a RenderViewHost is pending shutdown for this |site_instance|, put it
183 // in the map of RenderViewHosts pending shutdown. Otherwise there should 203 // in the map of RenderViewHosts pending shutdown. Otherwise return the
184 // not be a RenderViewHost for the SiteInstance. 204 // existing RenderViewHost for the SiteInstance.
185 CHECK_EQ(RenderViewHostImpl::STATE_PENDING_SHUTDOWN, 205 if (iter->second->rvh_state() == RenderViewHostImpl::STATE_PENDING_SHUTDOWN) {
186 iter->second->rvh_state()); 206 render_view_host_pending_shutdown_map_.insert(
187 render_view_host_pending_shutdown_map_.insert( 207 std::pair<int, RenderViewHostImpl*>(site_instance->GetId(),
188 std::pair<int, RenderViewHostImpl*>(site_instance->GetId(), 208 iter->second));
189 iter->second)); 209 render_view_host_map_.erase(iter);
190 render_view_host_map_.erase(iter); 210 LOG(ERROR) << "FT::CreateRVHForMainFrame: rvh found and erased";
211 } else {
212 return iter->second;
213 }
191 } 214 }
192 RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>( 215 RenderViewHostImpl* rvh = static_cast<RenderViewHostImpl*>(
193 RenderViewHostFactory::Create(site_instance, 216 RenderViewHostFactory::Create(site_instance,
194 render_view_delegate_, 217 render_view_delegate_,
195 render_widget_delegate_, 218 render_widget_delegate_,
196 routing_id, 219 routing_id,
197 main_frame_routing_id, 220 main_frame_routing_id,
198 swapped_out, 221 swapped_out,
199 hidden)); 222 hidden));
200 223
201 render_view_host_map_[site_instance->GetId()] = rvh; 224 render_view_host_map_[site_instance->GetId()] = rvh;
202 return rvh; 225 return rvh;
203 } 226 }
204 227
205 RenderViewHostImpl* FrameTree::GetRenderViewHostForSubFrame( 228 RenderViewHostImpl* FrameTree::GetRenderViewHost(
206 SiteInstance* site_instance) { 229 SiteInstance* site_instance) {
207 RenderViewHostMap::iterator iter = 230 RenderViewHostMap::iterator iter =
208 render_view_host_map_.find(site_instance->GetId()); 231 render_view_host_map_.find(site_instance->GetId());
209 // TODO(creis): Mirror the frame tree so this check can't fail. 232 // TODO(creis): Mirror the frame tree so this check can't fail.
210 if (iter == render_view_host_map_.end()) 233 if (iter == render_view_host_map_.end())
211 return NULL; 234 return NULL;
212 return iter->second; 235 return iter->second;
213 } 236 }
214 237
215 void FrameTree::RegisterRenderFrameHost( 238 void FrameTree::RegisterRenderFrameHost(
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 rvh->Shutdown(); 285 rvh->Shutdown();
263 render_view_host_pending_shutdown_map_.erase(multi_iter); 286 render_view_host_pending_shutdown_map_.erase(multi_iter);
264 } 287 }
265 break; 288 break;
266 } 289 }
267 CHECK(render_view_host_found); 290 CHECK(render_view_host_found);
268 } 291 }
269 } 292 }
270 293
271 } // namespace content 294 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/frame_tree.h ('k') | content/browser/frame_host/frame_tree_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698