Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2412213002: Revert of Disable service_worker.service_worker_micro_benchmark on Android WebView Perf (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
Reviewers:
Zhen Wang
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable service_worker.service_worker_micro_benchmark on Android WebView Perf (patchset #1 id:1 of https://codereview.chromium.org/2402703002/ ) Reason for revert: The benchmark should be runnable on webview now. Original issue's description: > Disable service_worker.service_worker_micro_benchmark on Android WebView Perf > > TBR=nednguyen@google.com > BUG=chromium:653924 > > Committed: https://crrev.com/15ca7de391cdb9731e00426e9c524160ae2d7347 > Cr-Commit-Position: refs/heads/master@{#424047} TBR=zhenw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:653924 Committed: https://crrev.com/2b1cd31e7d0a45eac02a7fce8c792484f528b4cc Cr-Commit-Position: refs/heads/master@{#424818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/benchmarks/service_worker.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
Created Revert of Disable service_worker.service_worker_micro_benchmark on Android WebView Perf
4 years, 2 months ago (2016-10-12 18:18:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412213002/1
4 years, 2 months ago (2016-10-12 18:19:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 19:23:37 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b1cd31e7d0a45eac02a7fce8c792484f528b4cc Cr-Commit-Position: refs/heads/master@{#424818}
4 years, 2 months ago (2016-10-12 19:26:40 UTC) #6
shimazu
4 years, 2 months ago (2016-10-13 04:14:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2412983005/ by shimazu@chromium.org.

The reason for reverting is: This still breaks the tests..

Powered by Google App Engine
This is Rietveld 408576698