[Sync] Move SharedModelTypeProcessor to model_impl/.

[Sync] Move SharedModelTypeProcessor to model_impl/.

- Move shared_model_type_processor* to model_impl/
- Move processor_entity_tracker* to model_impl/
- Replace SharedModelTypeProcessor::CreateAsChangeProcessor() with
  ModelTypeChangeProcessor::Create().
- Remove model_type_connector_proxy_unittest.cc as it mostly just tests
  WeakPtr functionality or things covered in the worker tests.
- Introduce ModelTypeDebugInfo, a friend class of SMTP, to hold all the
  debug logic Gang has been adding to SMTP.
- An unrelated cleanup tweak in the worker test.

BUG=631271
Committed: https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5
Cr-Commit-Position: refs/heads/master@{#424921}

[maxbogue, 2016-10-12 18:02:46]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 18:03:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-12 18:11:24]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-10-12 18:11:24]

Sky, PTAL! Note that the SMTP test file should be a very easy merge :P

[commit-bot: I haz the power, 2016-10-12 19:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 19:13:27]

Dry run: This issue passed the CQ dry run.

[skym, 2016-10-12 21:53:45]

lgtm

https://codereview.chromium.org/2412193002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/model_type_worker_unittest.cc (right):

https://codereview.chromium.org/2412193002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_worker_unittest.cc:182:
processor->SetDisconnectCallback(base::Bind(
I think it's weird that you assign mock_type_processor_ after calling
SetDisconnectCallback. Why not the other way around?

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
File components/sync/model/model_type_debug_info.cc (right):

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
components/sync/model/model_type_debug_info.cc:24:
static_cast<SharedModelTypeProcessor*>(service->change_processor());
This is still hacky, and still deserves a TODO.

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
File components/sync/model/model_type_debug_info.h (right):

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
components/sync/model/model_type_debug_info.h:20: // class because it is a
friend class to SharedModelTypeProcessor.
Well justified.

[maxbogue, 2016-10-12 22:48:55]

https://codereview.chromium.org/2412193002/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/model_type_worker_unittest.cc (right):

https://codereview.chromium.org/2412193002/diff/1/components/sync/engine_impl...
components/sync/engine_impl/model_type_worker_unittest.cc:182:
processor->SetDisconnectCallback(base::Bind(
On 2016/10/12 21:53:45, skym wrote:
> I think it's weird that you assign mock_type_processor_ after calling
> SetDisconnectCallback. Why not the other way around?

*shrug*. Changed.

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
File components/sync/model/model_type_debug_info.cc (right):

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
components/sync/model/model_type_debug_info.cc:24:
static_cast<SharedModelTypeProcessor*>(service->change_processor());
On 2016/10/12 21:53:45, skym wrote:
> This is still hacky, and still deserves a TODO.

We discussed this offline and I convinced Sky that knowledge of SMTP as the
implementation within model/ is fine :)

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
File components/sync/model/model_type_debug_info.h (right):

https://codereview.chromium.org/2412193002/diff/1/components/sync/model/model...
components/sync/model/model_type_debug_info.h:20: // class because it is a
friend class to SharedModelTypeProcessor.
On 2016/10/12 21:53:45, skym wrote:
> Well justified.

Acknowledged.

[maxbogue, 2016-10-12 22:49:01]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-10-12 22:49:01]

The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2412193002/#ps20001
(title: "Address comment from Sky.")

[commit-bot: I haz the power, 2016-10-12 22:49:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 00:33:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 00:36:36]

Description was changed from

==========
[Sync] Move SharedModelTypeProcessor to model_impl/.

- Move shared_model_type_processor* to model_impl/
- Move processor_entity_tracker* to model_impl/
- Replace SharedModelTypeProcessor::CreateAsChangeProcessor() with
  ModelTypeChangeProcessor::Create().
- Remove model_type_connector_proxy_unittest.cc as it mostly just tests
  WeakPtr functionality or things covered in the worker tests.
- Introduce ModelTypeDebugInfo, a friend class of SMTP, to hold all the
  debug logic Gang has been adding to SMTP.
- An unrelated cleanup tweak in the worker test.

BUG=631271
==========

to

==========
[Sync] Move SharedModelTypeProcessor to model_impl/.

- Move shared_model_type_processor* to model_impl/
- Move processor_entity_tracker* to model_impl/
- Replace SharedModelTypeProcessor::CreateAsChangeProcessor() with
  ModelTypeChangeProcessor::Create().
- Remove model_type_connector_proxy_unittest.cc as it mostly just tests
  WeakPtr functionality or things covered in the worker tests.
- Introduce ModelTypeDebugInfo, a friend class of SMTP, to hold all the
  debug logic Gang has been adding to SMTP.
- An unrelated cleanup tweak in the worker test.

BUG=631271

Committed: https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5
Cr-Commit-Position: refs/heads/master@{#424921}
==========

[commit-bot: I haz the power, 2016-10-13 00:36:37]

Patchset 2 (id:??) landed as
https://crrev.com/2a1e232d951e2069ca2cb98e5beb6923a13036a5
Cr-Commit-Position: refs/heads/master@{#424921}