views: add selection change animation to TabbedPane

views: add selection change animation to TabbedPane

The Harmony spec calls for these to follow the Paper Tab animations,
which are as follows:

1) Over 0.15s, the selection bar grows to encompass the new selection,
   growing along the cubic bezier curve (0.4, 0.0, 1.0, 1.0), which matches
   gfx::Tween::FAST_OUT_LINEAR_IN;
2) Over 0.18s, the selection bar shrinks to encompass only the new
   selection, shrinking along the cubic bezier curve (0.0, 0.0, 0.2, 1.0),
   which matches gfx::Tween::LINEAR_OUT_SLOW_IN.

This change:
1) Removes border painting from MdTab altogether;
2) Changes MdTabStrip to paint the current selection bar;
3) Introduces TabStrip::OnSelectedTabChanged() as a callback for
   TabStrip to learn when the selected Tab has changed;
4) Adds expand and contract animations to MdTabStrip;
5) Grows and shrinks the selection bar in accordance with those
   animations.

BUG=635176
Committed: https://crrev.com/8002657452fc6b81b73ce8c77713b938080c9a2d
Cr-Commit-Position: refs/heads/master@{#425095}

[Elly Fong-Jones, 2016-10-13 14:28:47]

Description was changed from

==========
views: add selection change animation to TabbedPane

The Harmony spec calls for these to follow the Paper Tab animations,
which are as follows:

1) Over 0.15s, the selection bar grows to encompass the new selection,
   growing along the cubic bezier curve (0.4, 0.0, 1.0, 1.0), which matches
   gfx::Tween::FAST_OUT_LINEAR_IN;
2) Over 0.18s, the selection bar shrinks to encompass only the new
   selection, shrinking along the cubic bezier curve (0.0, 0.0, 0.2, 1.0),
   which matches gfx::Tween::LINEAR_OUT_SLOW_IN.

This change:
1) Removes border painting from MdTab altogether;
2) Changes MdTabStrip to paint the current selection bar;
3) Introduces TabStrip::OnSelectedTabChanged() as a callback for
   TabStrip to learn when the selected Tab has changed;
4) Adds expand and contract animations to MdTabStrip;
5) Grows and shrinks the selection bar in accordance with those
   animations.

BUG=635176
==========

to

==========
views: add selection change animation to TabbedPane

The Harmony spec calls for these to follow the Paper Tab animations,
which are as follows:

1) Over 0.15s, the selection bar grows to encompass the new selection,
   growing along the cubic bezier curve (0.4, 0.0, 1.0, 1.0), which matches
   gfx::Tween::FAST_OUT_LINEAR_IN;
2) Over 0.18s, the selection bar shrinks to encompass only the new
   selection, shrinking along the cubic bezier curve (0.0, 0.0, 0.2, 1.0),
   which matches gfx::Tween::LINEAR_OUT_SLOW_IN.

This change:
1) Removes border painting from MdTab altogether;
2) Changes MdTabStrip to paint the current selection bar;
3) Introduces TabStrip::OnSelectedTabChanged() as a callback for
   TabStrip to learn when the selected Tab has changed;
4) Adds expand and contract animations to MdTabStrip;
5) Grows and shrinks the selection bar in accordance with those
   animations.

BUG=635176
==========

[Elly Fong-Jones, 2016-10-13 14:28:47]

ellyjones@chromium.org changed reviewers:
+ msw@chromium.org

[Elly Fong-Jones, 2016-10-13 14:28:52]

msw: ptal? :)

[msw, 2016-10-13 17:08:26]

nice documentation; lgtm with nits.

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
File ui/views/controls/tabbed_pane/tabbed_pane.cc (right):

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
ui/views/controls/tabbed_pane/tabbed_pane.cc:397: // These durations are ripped
off from the Paper Tabs source:
nit: s/ripped off/taken/

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
ui/views/controls/tabbed_pane/tabbed_pane.cc:398: //
https://github.com/PolymerElements/paper-tabs/blob/master/paper-tabs.html#L197
nit: maybe mention selectionBar.expand and selectionBar.contract in addition to
(or instead of) giving a line number that might easily change.

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
ui/views/controls/tabbed_pane/tabbed_pane.cc:479: if (min_x != max_x) {
q: When would this ever be the case? DCHECK instead?

[Elly Fong-Jones, 2016-10-13 17:12:50]

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
File ui/views/controls/tabbed_pane/tabbed_pane.cc (right):

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
ui/views/controls/tabbed_pane/tabbed_pane.cc:397: // These durations are ripped
off from the Paper Tabs source:
On 2016/10/13 17:08:26, msw wrote:
> nit: s/ripped off/taken/

Done.

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
ui/views/controls/tabbed_pane/tabbed_pane.cc:398: //
https://github.com/PolymerElements/paper-tabs/blob/master/paper-tabs.html#L197
On 2016/10/13 17:08:26, msw wrote:
> nit: maybe mention selectionBar.expand and selectionBar.contract in addition
to
> (or instead of) giving a line number that might easily change.

Done.

https://codereview.chromium.org/2412163003/diff/20001/ui/views/controls/tabbe...
ui/views/controls/tabbed_pane/tabbed_pane.cc:479: if (min_x != max_x) {
On 2016/10/13 17:08:26, msw wrote:
> q: When would this ever be the case? DCHECK instead?

Only if there's no selected tab, which is rare but possible. Moved the check up
above.

[Elly Fong-Jones, 2016-10-13 17:12:57]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2016-10-13 17:13:04]

sky: ptal? :)

[sky, 2016-10-13 17:30:45]

As Mike reviews this already, Rubber stamp LGTM

[Elly Fong-Jones, 2016-10-13 17:33:51]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-10-13 17:33:52]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2412163003/#ps40001
(title: "nits fixed")

[commit-bot: I haz the power, 2016-10-13 17:34:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 18:25:01]

Description was changed from

==========
views: add selection change animation to TabbedPane

The Harmony spec calls for these to follow the Paper Tab animations,
which are as follows:

1) Over 0.15s, the selection bar grows to encompass the new selection,
   growing along the cubic bezier curve (0.4, 0.0, 1.0, 1.0), which matches
   gfx::Tween::FAST_OUT_LINEAR_IN;
2) Over 0.18s, the selection bar shrinks to encompass only the new
   selection, shrinking along the cubic bezier curve (0.0, 0.0, 0.2, 1.0),
   which matches gfx::Tween::LINEAR_OUT_SLOW_IN.

This change:
1) Removes border painting from MdTab altogether;
2) Changes MdTabStrip to paint the current selection bar;
3) Introduces TabStrip::OnSelectedTabChanged() as a callback for
   TabStrip to learn when the selected Tab has changed;
4) Adds expand and contract animations to MdTabStrip;
5) Grows and shrinks the selection bar in accordance with those
   animations.

BUG=635176
==========

to

==========
views: add selection change animation to TabbedPane

The Harmony spec calls for these to follow the Paper Tab animations,
which are as follows:

1) Over 0.15s, the selection bar grows to encompass the new selection,
   growing along the cubic bezier curve (0.4, 0.0, 1.0, 1.0), which matches
   gfx::Tween::FAST_OUT_LINEAR_IN;
2) Over 0.18s, the selection bar shrinks to encompass only the new
   selection, shrinking along the cubic bezier curve (0.0, 0.0, 0.2, 1.0),
   which matches gfx::Tween::LINEAR_OUT_SLOW_IN.

This change:
1) Removes border painting from MdTab altogether;
2) Changes MdTabStrip to paint the current selection bar;
3) Introduces TabStrip::OnSelectedTabChanged() as a callback for
   TabStrip to learn when the selected Tab has changed;
4) Adds expand and contract animations to MdTabStrip;
5) Grows and shrinks the selection bar in accordance with those
   animations.

BUG=635176
==========

[commit-bot: I haz the power, 2016-10-13 18:25:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-13 18:28:11]

Description was changed from

==========
views: add selection change animation to TabbedPane

The Harmony spec calls for these to follow the Paper Tab animations,
which are as follows:

1) Over 0.15s, the selection bar grows to encompass the new selection,
   growing along the cubic bezier curve (0.4, 0.0, 1.0, 1.0), which matches
   gfx::Tween::FAST_OUT_LINEAR_IN;
2) Over 0.18s, the selection bar shrinks to encompass only the new
   selection, shrinking along the cubic bezier curve (0.0, 0.0, 0.2, 1.0),
   which matches gfx::Tween::LINEAR_OUT_SLOW_IN.

This change:
1) Removes border painting from MdTab altogether;
2) Changes MdTabStrip to paint the current selection bar;
3) Introduces TabStrip::OnSelectedTabChanged() as a callback for
   TabStrip to learn when the selected Tab has changed;
4) Adds expand and contract animations to MdTabStrip;
5) Grows and shrinks the selection bar in accordance with those
   animations.

BUG=635176
==========

to

==========
views: add selection change animation to TabbedPane

The Harmony spec calls for these to follow the Paper Tab animations,
which are as follows:

1) Over 0.15s, the selection bar grows to encompass the new selection,
   growing along the cubic bezier curve (0.4, 0.0, 1.0, 1.0), which matches
   gfx::Tween::FAST_OUT_LINEAR_IN;
2) Over 0.18s, the selection bar shrinks to encompass only the new
   selection, shrinking along the cubic bezier curve (0.0, 0.0, 0.2, 1.0),
   which matches gfx::Tween::LINEAR_OUT_SLOW_IN.

This change:
1) Removes border painting from MdTab altogether;
2) Changes MdTabStrip to paint the current selection bar;
3) Introduces TabStrip::OnSelectedTabChanged() as a callback for
   TabStrip to learn when the selected Tab has changed;
4) Adds expand and contract animations to MdTabStrip;
5) Grows and shrinks the selection bar in accordance with those
   animations.

BUG=635176

Committed: https://crrev.com/8002657452fc6b81b73ce8c77713b938080c9a2d
Cr-Commit-Position: refs/heads/master@{#425095}
==========

[commit-bot: I haz the power, 2016-10-13 18:28:14]

Patchset 3 (id:??) landed as
https://crrev.com/8002657452fc6b81b73ce8c77713b938080c9a2d
Cr-Commit-Position: refs/heads/master@{#425095}