Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 241213002: Don't compile events.gyp:events on Android. (Closed)

Created:
6 years, 8 months ago by tdresser
Modified:
6 years, 8 months ago
Reviewers:
jdduke (slow), sky
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org, jdduke (slow)
Visibility:
Public.

Description

Don't compile events.gyp:events on Android. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265631

Patch Set 1 #

Total comments: 1

Patch Set 2 : Don't include ime.gypi on Android at all. #

Total comments: 1

Patch Set 3 : Don't include browser_ui_views on Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/ime/ime.gypi View 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tdresser
sky@, can you take a look? It feels like I may be fixing a symptom ...
6 years, 8 months ago (2014-04-17 19:40:05 UTC) #1
jdduke (slow)
So it looks like Android really doesn't use ime.gyp, but it does get linked in ...
6 years, 8 months ago (2014-04-17 20:03:42 UTC) #2
sky
https://codereview.chromium.org/241213002/diff/10001/chrome/chrome_browser_ui_views.gyp File chrome/chrome_browser_ui_views.gyp (right): https://codereview.chromium.org/241213002/diff/10001/chrome/chrome_browser_ui_views.gyp#newcode11 chrome/chrome_browser_ui_views.gyp:11: 'target_name': 'browser_ui_views', Why is the change needed here? android ...
6 years, 8 months ago (2014-04-17 22:00:19 UTC) #3
tdresser
Android was depending on browser_ui_views. How does this look?
6 years, 8 months ago (2014-04-22 20:44:23 UTC) #4
sky
LGTM
6 years, 8 months ago (2014-04-22 22:15:39 UTC) #5
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 8 months ago (2014-04-23 12:24:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/241213002/40001
6 years, 8 months ago (2014-04-23 12:24:56 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 13:46:15 UTC) #8
Message was sent while issue was closed.
Change committed as 265631

Powered by Google App Engine
This is Rietveld 408576698