Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2412023002: DevTools: migrate InspectorView to tabbed view location. (Closed)

Created:
4 years, 2 months ago by pfeldman
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, michaeln, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate InspectorView to tabbed view location. Committed: https://crrev.com/2cbfc042012e00bc5863caa8c55de9d25f71d5e3 Cr-Commit-Position: refs/heads/master@{#424895}

Patch Set 1 #

Patch Set 2 : test fixed #

Total comments: 25

Patch Set 3 : review comments addressed. #

Patch Set 4 : made layers panel closeable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -530 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/appcache/appcache-iframe-manifests.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/appcache/appcache-swap.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/extensions-test.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/resources-panel.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/source-frame-replace-1.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/source-frame-replace-2.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/source-frame-replace-3.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/source-frame-replace-4.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/source-frame-search.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-shadow-1.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/edit-dom-actions-shadow-2.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/highlight/highlight-dom-updates.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/shadow/reveal-shadow-dom-node.html View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 2 6 chunks +11 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel-expected.txt View 1 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-resources.html View 1 2 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/scroll-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-auto-record.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-receive-response-event.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/user-metrics.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Settings.js View 3 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/module.json View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 6 chunks +12 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/AdvancedApp.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 2 chunks +21 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/layers/module.json View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 3 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/SimpleApp.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 2 3 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/module.json View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 3 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastApp.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 7 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/module.json View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 2 10 chunks +26 lines, -290 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Panel.js View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 1 2 11 chunks +76 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
pfeldman
4 years, 2 months ago (2016-10-12 00:18:52 UTC) #2
dgozman
Great patch! https://codereview.chromium.org/2412023002/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js File third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js (right): https://codereview.chromium.org/2412023002/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js#newcode140 third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js:140: WebInspector.ConsolePanel.show = function() Let's maybe remove this ...
4 years, 2 months ago (2016-10-12 04:47:41 UTC) #7
pfeldman
https://codereview.chromium.org/2412023002/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js File third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js (right): https://codereview.chromium.org/2412023002/diff/20001/third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js#newcode140 third_party/WebKit/Source/devtools/front_end/console/ConsolePanel.js:140: WebInspector.ConsolePanel.show = function() On 2016/10/12 04:47:40, dgozman wrote: > ...
4 years, 2 months ago (2016-10-12 19:02:34 UTC) #8
dgozman
lgtm salads
4 years, 2 months ago (2016-10-12 19:23:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2412023002/60001
4 years, 2 months ago (2016-10-12 22:49:35 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-12 22:58:15 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 23:00:00 UTC) #20
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2cbfc042012e00bc5863caa8c55de9d25f71d5e3
Cr-Commit-Position: refs/heads/master@{#424895}

Powered by Google App Engine
This is Rietveld 408576698