Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/resources/md_history/app.vulcanized.html

Issue 2412003002: MD History: Fix overlapping of sidebar footer in very short windows (Closed)
Patch Set: Layout tweaks Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/app.vulcanized.html
diff --git a/chrome/browser/resources/md_history/app.vulcanized.html b/chrome/browser/resources/md_history/app.vulcanized.html
index 4a0a8b2701e2356e0cd406a7e99587b2b473455d..68883b6738e4f1b3fb37d71b14794b93ff0c3ba8 100644
--- a/chrome/browser/resources/md_history/app.vulcanized.html
+++ b/chrome/browser/resources/md_history/app.vulcanized.html
@@ -3665,14 +3665,21 @@ button.more-vert-button div {
}
:host {
- display: block;
+ display: flex;
+ flex-direction: column;
height: 100%;
- padding-top: 5px;
+ overflow-x: hidden;
+ overflow-y: auto;
width: var(--side-bar-width);
}
+:host([drawer]) {
+ height: calc(100% - var(--toolbar-height));
+}
+
div.separator {
background-color: rgba(0, 0, 0, 0.08);
+ flex-shrink: 0;
height: 1px;
margin: 8px 0;
}
@@ -3694,6 +3701,10 @@ iron-selector {
-webkit-user-select: none;
background-color: transparent;
color: #5a5a5a;
+ display: flex;
+ flex: 1;
+ flex-direction: column;
+ padding-top: 5px;
}
iron-selector > a {
@@ -3713,18 +3724,15 @@ iron-selector > a {
iron-selector > a.iron-selected {
color: var(--google-blue-500);
- font-weight: 500;
}
-#footer {
- bottom: 0;
- color: var(--paper-grey-600);
- position: absolute;
- width: var(--side-bar-width);
+#spacer {
+ flex: 1;
}
-:host([drawer]) #footer {
- bottom: 120px;
+#footer {
+ color: var(--paper-grey-600);
+ width: var(--side-bar-width);
}
#footer-text {
@@ -3756,6 +3764,7 @@ iron-selector > a.iron-selected {
<iron-icon icon="cr:open-in-new"></iron-icon>
<paper-ripple id="cbd-ripple"></paper-ripple>
</a>
+ <div id="spacer"></div>
<div id="footer" hidden="[[!showFooter]]">
<div class="separator"></div>
<div id="footer-text">$i18nRaw{sidebarFooter}</div>
@@ -3885,9 +3894,9 @@ history-toolbar {
#drawer-header {
align-items: center;
border-bottom: 1px solid rgba(0, 0, 0, 0.08);
+ box-sizing: border-box;
display: flex;
height: var(--toolbar-height);
- margin-bottom: 5px;
}
h1 {

Powered by Google App Engine
This is Rietveld 408576698