Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2411973004: Move WebTextInputType and WebTextInputInfo into platform. (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
Shu Chen, esprehn, boliu
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebTextInputType and WebTextInputInfo into platform. Moving these types into platform will allow the Editor class to provide the implementation as opposed to a wrapper inside WebViewImpl which it is today. BUG=634330 TBR=shuchen@chromium.org, boliu@chromium.org Committed: https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8 Cr-Commit-Position: refs/heads/master@{#425050}

Patch Set 1 #

Patch Set 2 : Fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -232 lines) Patch
M content/browser/DEPS View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/WebTextInputInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/web/WebTextInputInfo.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/public/platform/WebTextInputInfo.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/public/platform/WebTextInputType.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/public/web/WebTextInputInfo.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/public/web/WebTextInputType.h View 1 chunk +0 lines, -94 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/text_input_flags.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/text_input_type.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (13 generated)
dtapuska
4 years, 2 months ago (2016-10-12 18:12:15 UTC) #3
dtapuska
4 years, 2 months ago (2016-10-12 18:13:05 UTC) #5
esprehn
lgtm
4 years, 2 months ago (2016-10-12 21:05:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411973004/1
4 years, 2 months ago (2016-10-12 22:35:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/279800)
4 years, 2 months ago (2016-10-12 22:42:58 UTC) #12
esprehn
On 2016/10/12 at 22:42:58, commit-bot wrote: > Try jobs failed on following builders: > chromium_presubmit ...
4 years, 2 months ago (2016-10-13 04:01:49 UTC) #13
dtapuska
4 years, 2 months ago (2016-10-13 14:26:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411973004/20001
4 years, 2 months ago (2016-10-13 14:27:26 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 16:09:57 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7f4ddc2a0e365f9730782148c6f58444dcf470e8 Cr-Commit-Position: refs/heads/master@{#425050}
4 years, 2 months ago (2016-10-13 16:12:12 UTC) #23
boliu
4 years, 2 months ago (2016-10-13 16:40:01 UTC) #24
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698