Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2411943002: [css-flexbox] Don't force layout for overflow: auto anymore (Closed)

Created:
4 years, 2 months ago by cbiesinger
Modified:
4 years, 2 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Don't force layout for overflow: auto anymore Now that we include the scrollbar in the preferred width due to these changes: https://chromium.googlesource.com/chromium/src/+/c9b3e99e2a71f7bcc4d9652916347782ff616e0d https://chromium.googlesource.com/chromium/src/+/906252430fe0108cf163f1fd9c2e96aa283f9cb5%5E%21/ we no longer need to force layout to include the scrollbar in the flex item size as the above code makes this work correctly. This should help a bit with performance, too. (The listed bug is somewhat optimistic; it may help but I haven't really investigated yet) R=eae@chromium.org,dgrogan@chromium.org TEST=n/a, no behavior change BUG=649988 Committed: https://crrev.com/c03addfdbc3e63d0df45e83f14b6c8d12572ef4b Cr-Commit-Position: refs/heads/master@{#424632}

Patch Set 1 #

Patch Set 2 : further simplify & add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 3 chunks +6 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
cbiesinger
4 years, 2 months ago (2016-10-11 21:10:52 UTC) #1
eae
Very nice, LGTM
4 years, 2 months ago (2016-10-11 21:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411943002/20001
4 years, 2 months ago (2016-10-11 22:53:07 UTC) #10
szager1
drive-by lgtm
4 years, 2 months ago (2016-10-11 23:35:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 01:21:48 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:23:17 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c03addfdbc3e63d0df45e83f14b6c8d12572ef4b
Cr-Commit-Position: refs/heads/master@{#424632}

Powered by Google App Engine
This is Rietveld 408576698