components/autofill/content/renderer/password_autofill_agent.h - Issue 241193002: Password autofill: Check for user gesture switches to new Blink backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 241193002: Password autofill: Check for user gesture switches to new Blink backend (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: OVERRIDE removed test enabled Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index f814dfdfd972da509f7d46a84582768e6746591f..582f331b3d5fb15dcdb2ecf0a006b7cc661866b8 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -53,6 +53,11 @@ class PasswordAutofillAgent : public content::RenderViewObserver {

// Called when new form controls are inserted.

void OnDynamicFormsSeen(blink::WebFrame* frame);

+ // Called when the user first interacts with the page after a load. This is a

+ // signal to make autofilled values of password input elements accessible to

+ // JavaScript.

+ void FirstUserGestureObserved();

protected:

virtual bool OriginCanAccessPasswordManager(

const blink::WebSecurityOrigin& origin);

@@ -120,7 +125,6 @@ class PasswordAutofillAgent : public content::RenderViewObserver {

const blink::WebFormElement& form) OVERRIDE;

virtual void WillSubmitForm(blink::WebLocalFrame* frame,

const blink::WebFormElement& form) OVERRIDE;

- virtual void WillProcessUserGesture() OVERRIDE;

// RenderView IPC handlers:

void OnFillPasswordForm(const PasswordFormFillData& form_data);