Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2411923004: Stop including roboto.woff files on Android (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop including roboto.woff files on Android They were never meant to be included. BUG=654981 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ca3d5a3a1c2b9e5ca72a47d34a4dc414ad25f952 Cr-Commit-Position: refs/heads/master@{#425134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/webui/resources/css/roboto.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
agrieve
Looks like it was just a typo :P
4 years, 2 months ago (2016-10-13 13:36:16 UTC) #7
Dan Beam
ahhhh lgtm
4 years, 2 months ago (2016-10-13 16:51:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411923004/1
4 years, 2 months ago (2016-10-13 19:53:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 19:58:51 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 20:02:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca3d5a3a1c2b9e5ca72a47d34a4dc414ad25f952
Cr-Commit-Position: refs/heads/master@{#425134}

Powered by Google App Engine
This is Rietveld 408576698