Source/web/WebDevToolsFrontendImpl.cpp - Issue 24119002: Fix r157217, committed patch set didn't contain the latest review modifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebDevToolsFrontendImpl.cpp

Issue 24119002: Fix r157217, committed patch set didn't contain the latest review modifications. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebDevToolsFrontendImpl.cpp

diff --git a/Source/web/WebDevToolsFrontendImpl.cpp b/Source/web/WebDevToolsFrontendImpl.cpp

index affd937570e7467f71dca0f9d32c53b06feff9dd..48a82ad4519679c7548ba2cdb480ddb20e034190 100644

--- a/Source/web/WebDevToolsFrontendImpl.cpp

+++ b/Source/web/WebDevToolsFrontendImpl.cpp

@@ -148,7 +148,7 @@ void WebDevToolsFrontendImpl::doDispatchOnInspectorFrontend(const WebString& mes

WebFrameImpl* frame = m_webViewImpl->mainFrameImpl();

if (!frame->frame())

return;

- v8::Isolate* isolate = frame->frame()->script()->isolate();

+ v8::Isolate* isolate = getIsolateFromFrame(frame->frame());

v8::HandleScope scope(isolate);

v8::Handle<v8::Context> frameContext = frame->frame()->script()->currentWorldContext();

v8::Context::Scope contextScope(frameContext);

« Source/bindings/v8/V8Binding.h ('K') | « Source/core/inspector/InspectorOverlay.cpp ('k') | Source/web/tests/CustomEventTest.cpp » ('j') | no next file with comments »