Source/bindings/v8/ScriptState.cpp - Issue 24119002: Fix r157217, committed patch set didn't contain the latest review modifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptState.cpp

Issue 24119002: Fix r157217, committed patch set didn't contain the latest review modifications. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/ScriptState.cpp

diff --git a/Source/bindings/v8/ScriptState.cpp b/Source/bindings/v8/ScriptState.cpp

index e7856417c0db1b417fbb70d9f62e4ec69dd6ac40..fe959a5798ebd04edfb13a8a1dca1a4e88e599bd 100644

--- a/Source/bindings/v8/ScriptState.cpp

+++ b/Source/bindings/v8/ScriptState.cpp

@@ -109,7 +109,7 @@ void ScriptState::setEvalEnabled(bool enabled)

ScriptState* mainWorldScriptState(Frame* frame)

{

- v8::HandleScope handleScope(frame->script()->isolate());

+ v8::HandleScope handleScope(getIsolateFromFrame(frame));

return ScriptState::forContext(frame->script()->mainWorldContext());

}

« no previous file with comments | « Source/bindings/v8/ScriptEventListener.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | Source/bindings/v8/V8Binding.h » ('J')