Issue 24119002: Fix r157217, committed patch set didn't contain the latest review modifications.

Issue 24119002: Fix r157217, committed patch set didn't contain the latest review modifications. (Closed)

Created:
7 years, 3 months ago by marja

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix r157217, committed patch set didn't contain the latest review modifications. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157674

Patch Set 1 #

Total comments: 1

Patch Set 2 : naming #

Patch Set 3 : . #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -22 lines)			Patch
M	Source/bindings/v8/DOMRequestState.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptEventListener.cpp	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/ScriptState.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8Binding.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/bindings/v8/V8Binding.cpp	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/bindings/v8/V8LazyEventListener.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorIndexedDBAgent.cpp	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorOverlay.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebDevToolsFrontendImpl.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/tests/CustomEventTest.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/24119002/diff/1/Source/bindings/v8/V8Binding.h File Source/bindings/v8/V8Binding.h (right): https://codereview.chromium.org/24119002/diff/1/Source/bindings/v8/V8Binding.h#newcode639 Source/bindings/v8/V8Binding.h:639: v8::Isolate* getIsolateFromFrame(Frame*); All these get prefixes are against the ...

7 years, 3 months ago (2013-09-12 07:54:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/24119002/6001

7 years, 3 months ago (2013-09-12 08:13:24 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=5306

7 years, 3 months ago (2013-09-12 10:03:15 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/24119002/6001

7 years, 3 months ago (2013-09-12 10:35:38 UTC) #5

Message was sent while issue was closed.

Change committed as 157674

Expand Messages | Collapse Messages