appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py - Issue 2411893002: [Findit] Adding metadata for manually vs automatically triggered flake analyses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py

Issue 2411893002: [Findit] Adding metadata for manually vs automatically triggered flake analyses (Closed)

Patch Set: Addressing comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/waterfall/flake/test/triggering_sources_test.py ('k') | appengine/findit/waterfall/flake/triggering_sources.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py

diff --git a/appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py b/appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py

index a266ca8311ddf4bf6c1ae9f5e02bed00467bd277..54f82a897daf94955b8e9064a53a2101f2db8919 100644

--- a/appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py

+++ b/appengine/findit/waterfall/flake/trigger_flake_analyses_pipeline.py

@@ -4,13 +4,13 @@

import logging

-from common import constants

from common import time_util

from common.pipeline_wrapper import BasePipeline

from model.flake. flake_analysis_request import FlakeAnalysisRequest

from model.wf_analysis import WfAnalysis

from model.wf_swarming_task import WfSwarmingTask

from waterfall.flake import flake_analysis_service

+from waterfall.flake import triggering_sources

class TriggerFlakeAnalysesPipeline(BasePipeline):

@@ -55,7 +55,8 @@ class TriggerFlakeAnalysesPipeline(BasePipeline):

master_name, builder_name, build_number, step,

time_util.GetUTCNow())

scheduled = flake_analysis_service.ScheduleAnalysisForFlake(

- request, 'findit-for-me@appspot.gserviceaccount.com', False)

+ request, 'findit-for-me@appspot.gserviceaccount.com', False,

+ triggering_sources.FINDIT_PIPELINE)

if scheduled: # pragma: no branch

logging.info('%s/%s/%s has %s flaky tests.',