Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1931)

Unified Diff: appengine/findit/model/flake/master_flake_analysis.py

Issue 2411893002: [Findit] Adding metadata for manually vs automatically triggered flake analyses (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/model/flake/master_flake_analysis.py
diff --git a/appengine/findit/model/flake/master_flake_analysis.py b/appengine/findit/model/flake/master_flake_analysis.py
index fde544cd7eb65a721c2702a44e4ce5c7b747a25d..8d4ff666234e155257b6ef6d1791ae66bc7401d3 100644
--- a/appengine/findit/model/flake/master_flake_analysis.py
+++ b/appengine/findit/model/flake/master_flake_analysis.py
@@ -6,11 +6,11 @@ import base64
from google.appengine.ext import ndb
-from model import analysis_status
from model.base_analysis import BaseAnalysis
from model.base_build_model import BaseBuildModel
from model.flake.flake_swarming_task import FlakeSwarmingTaskData
from model.versioned_model import VersionedModel
+from waterfall.flake import triggering_sources
class DataPoint(ndb.Model):
@@ -112,3 +112,12 @@ class MasterFlakeAnalysis(BaseAnalysis, BaseBuildModel, VersionedModel):
# The data points used to plot the flakiness graph build over build.
data_points = ndb.LocalStructuredProperty(
DataPoint, repeated=True, compressed=True)
+
+ # Whether the analysis was triggered by a manual request through check flake,
+ # Findit's automatic analysis upon detection, or Findit API.
+ triggering_source = ndb.IntegerProperty(
+ default=triggering_sources.FINDIT, indexed=True)
stgao 2016/10/13 06:14:38 The default value is not true for legacy data. May
lijeffrey 2016/10/14 23:45:21 Done.
+
+ # Who triggered the analysis. Used for differentiating between manual and
+ # automatic runs, and determining the most active users to gather feedback.
+ triggering_user_email = ndb.StringProperty(default=None, indexed=False)

Powered by Google App Engine
This is Rietveld 408576698