[Findit] Adding metadata for manually vs automatically triggered flake analyses

appengine/findit/waterfall/flake/flake_analysis_service.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from common import constants
 from model.flake.flake_analysis_request import FlakeAnalysisRequest
 from waterfall.flake import initialize_flake_pipeline
 from waterfall.flake import step_mapper
@@ skipping 158 matching lines @@
     return _MergeNewRequestIntoExistingOne(request, previous_request)
 
 
 def _IsAuthorizedUser(user_email):
   """Returns True if the given user email account  is authorized for access."""
   return user_email and (
       user_email in constants.WHITELISTED_APP_ACCOUNTS or
       user_email.endswith('@google.com'))
 
 
-def ScheduleAnalysisForFlake(request, user_email, is_admin):
+def ScheduleAnalysisForFlake(request, user_email, is_admin, triggering_source):
   """Schedules an analysis on the flake in the given request if needed.
 
   Args:
     request (FlakeAnalysisRequest): The request to analyze a flake.
     user_email (str): The email of the requester.
     is_admin (bool): Whether the requester is an admin.
+    triggering_source (int): Where the request is coming from, either Findit
+      itself or Findit API.

[stgao, 2016/10/13 06:14:38]

It could be Findit UI, Findit API, and Findit pipeline, right?

[lijeffrey, 2016/10/14 23:45:21]

Done.

 
   Returns:
     True if an analysis was scheduled; False if a new analysis is not needed;
     None if the user has no permission to.
   """
-  assert len(request.build_steps) > 0, 'At least 1 build step is needed!'
+  assert len(request.build_steps), 'At least 1 build step is needed!'
 
   if not is_admin and not _IsAuthorizedUser(user_email):
     return None
   request.user_emails = [user_email]
 
-  manually_triggered = user_email.endswith('@google.com')
-
   for build_step in request.build_steps:
     step_mapper.FindMatchingWaterfallStep(build_step)
 
   version_number, build_step = _CheckForNewAnalysis(request)
   if version_number and build_step:
     # A new analysis is needed.
     logging.info('A new analysis is needed for: %s', build_step)
     analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(
         build_step.wf_master_name, build_step.wf_builder_name,
         build_step.wf_build_number, build_step.wf_step_name,
         request.name, allow_new_analysis=True,
-        manually_triggered=manually_triggered,
+        user_email=user_email, triggering_source=triggering_source,
         queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
     if analysis:
       # TODO: put this in a transaction.
       request = FlakeAnalysisRequest.GetVersion(
           key=request.name, version=version_number)
       request.analyses.append(analysis.key)
       request.put()
       logging.info('A new analysis was triggered successfully: %s',
                    analysis.key)
       return True
     else:
-      logging.info('But no new analysis was not triggered!')
+      logging.error('But new analysis was not triggered!')
   else:
     logging.info('No new analysis is needed: %s', request)
 
   return False