Add SdkPatcher and implement top-level function / getter / setter patching.

Add SdkPatcher and implement top-level function / getter / setter patching.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9b2c5ce5b05bed5fe51cd9eef417b01ad361f71f

[Paul Berry, 2016-10-11 20:24:45]

https://codereview.chromium.org/2411883003/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/patch.dart (right):

https://codereview.chromium.org/2411883003/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:39: if (sdk is FolderBasedDartSdk) {
Will sdk ever not be FolderBasedDartSdk?  What should happen in that case?  It
could mask bugs if someone accidentally passes the wrong type to this function
and nothing happens.  Maybe it would be better to just change the argument type
to FolderBasedDartSdk so there's no confusion.

https://codereview.chromium.org/2411883003/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:44: SdkLibrary sdkLibrary =
sdk.getSdkLibrary(uriStr);
When patching a file that is a "part" of an SDK library, I think this will
return null, triggering the exception below.

[scheglov, 2016-10-11 20:34:08]

PTAL

https://codereview.chromium.org/2411883003/diff/1/pkg/analyzer/lib/src/dart/s...
File pkg/analyzer/lib/src/dart/sdk/patch.dart (right):

https://codereview.chromium.org/2411883003/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:39: if (sdk is FolderBasedDartSdk) {
On 2016/10/11 20:24:45, Paul Berry wrote:
> Will sdk ever not be FolderBasedDartSdk?  What should happen in that case?  It
> could mask bugs if someone accidentally passes the wrong type to this function
> and nothing happens.  Maybe it would be better to just change the argument
type
> to FolderBasedDartSdk so there's no confusion.

Done.

https://codereview.chromium.org/2411883003/diff/1/pkg/analyzer/lib/src/dart/s...
pkg/analyzer/lib/src/dart/sdk/patch.dart:44: SdkLibrary sdkLibrary =
sdk.getSdkLibrary(uriStr);
On 2016/10/11 20:24:45, Paul Berry wrote:
> When patching a file that is a "part" of an SDK library, I think this will
> return null, triggering the exception below.

I will add TODO for now.

[Brian Wilkerson, 2016-10-11 20:38:22]

lgtm

[Paul Berry, 2016-10-11 20:50:00]

lgtm

[scheglov, 2016-10-11 21:06:24]

Description was changed from

==========
Add SdkPatcher and implement top-level function / getter / setter patching.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Add SdkPatcher and implement top-level function / getter / setter patching.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9b2c5ce5b05bed5fe51cd9eef417b01ad361f71f
==========

[scheglov, 2016-10-11 21:06:26]

Committed patchset #2 (id:20001) manually as
9b2c5ce5b05bed5fe51cd9eef417b01ad361f71f (presubmit successful).