Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: test/cctest/interpreter/bytecode_expectations/Modules.golden

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Move logic to scope analysis time Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/Modules.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Modules.golden b/test/cctest/interpreter/bytecode_expectations/Modules.golden
index 62dbeb7ada9f1aa531d5443ed223dd7b1e1469f5..4921cf238912554d2a7fa463720d49953883fb1f 100644
--- a/test/cctest/interpreter/bytecode_expectations/Modules.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Modules.golden
@@ -153,7 +153,7 @@ snippet: "
"
frame size: 9
parameter count: 2
-bytecode array length: 223
+bytecode array length: 201
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(21),
@@ -213,16 +213,12 @@ bytecodes: [
B(LdaZero),
B(Star), R(7),
/* 32 E> */ B(CallRuntime), U16(Runtime::kLoadModuleImport), R(6), U8(2),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
- B(Star), R(8),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(8), U8(1),
B(Star), R(3),
B(LdaSmi), U8(42),
B(Star), R(5),
/* 32 E> */ B(Call), R(3), R(4), U8(2), U8(2),
B(Ldar), R(closure),
- B(CreateBlockContext), U8(3),
+ B(CreateBlockContext), U8(2),
B(PushContext), R(1),
B(LdaTheHole),
B(StaContextSlot), R(context), U8(4), U8(0),
@@ -234,10 +230,6 @@ bytecodes: [
B(LdaZero),
B(Star), R(7),
/* 52 E> */ B(CallRuntime), U16(Runtime::kLoadModuleImport), R(6), U8(2),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(2),
- B(Star), R(8),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(8), U8(1),
B(Star), R(3),
B(LdaSmi), U8(42),
B(Star), R(5),
@@ -249,7 +241,6 @@ bytecodes: [
constant pool: [
FIXED_ARRAY_TYPE,
ONE_BYTE_INTERNALIZED_STRING_TYPE ["foo"],
- ONE_BYTE_INTERNALIZED_STRING_TYPE ["goo"],
FIXED_ARRAY_TYPE,
]
handlers: [
@@ -365,7 +356,7 @@ snippet: "
"
frame size: 9
parameter count: 2
-bytecode array length: 242
+bytecode array length: 220
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(21),
@@ -432,10 +423,6 @@ bytecodes: [
/* 21 S> */ B(LdaConstant), U8(1),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kLoadModuleExport), R(3), U8(1),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(1),
- B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
B(Inc), U8(2),
B(Star), R(4),
B(LdaConstant), U8(1),
@@ -451,10 +438,6 @@ bytecodes: [
/* 39 S> */ B(LdaConstant), U8(1),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kLoadModuleExport), R(3), U8(1),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(1),
- B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
B(Inc), U8(3),
B(Star), R(4),
B(LdaConstant), U8(1),
@@ -480,7 +463,7 @@ snippet: "
"
frame size: 9
parameter count: 2
-bytecode array length: 230
+bytecode array length: 208
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(21),
@@ -547,10 +530,6 @@ bytecodes: [
/* 23 S> */ B(LdaConstant), U8(1),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kLoadModuleExport), R(3), U8(1),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(1),
- B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
B(Inc), U8(2),
/* 26 E> */ B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
B(Ldar), R(closure),
@@ -563,10 +542,6 @@ bytecodes: [
/* 41 S> */ B(LdaConstant), U8(1),
B(Star), R(3),
B(CallRuntime), U16(Runtime::kLoadModuleExport), R(3), U8(1),
- B(JumpIfNotHole), U8(11),
- B(LdaConstant), U8(1),
- B(Star), R(4),
- B(CallRuntime), U16(Runtime::kThrowReferenceError), R(4), U8(1),
B(Inc), U8(3),
/* 44 E> */ B(CallRuntime), U16(Runtime::kThrowConstAssignError), R(0), U8(0),
B(PopContext), R(1),

Powered by Google App Engine
This is Rietveld 408576698