src/full-codegen/full-codegen.h - Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.h

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)

Patch Set: Move logic to scope analysis time Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.h

diff --git a/src/full-codegen/full-codegen.h b/src/full-codegen/full-codegen.h

index 2a4eb9dd3b1a5802d44354be4f612704cdfc6286..c30712fe90610516d9f736ff5d1f66e4ffcd5af8 100644

--- a/src/full-codegen/full-codegen.h

+++ b/src/full-codegen/full-codegen.h

@@ -520,8 +520,6 @@ class FullCodeGenerator final : public AstVisitor<FullCodeGenerator> {

void EmitAccessor(ObjectLiteralProperty* property);

- bool NeedsHoleCheckForLoad(VariableProxy* proxy);

// Expects the arguments and the function already pushed.

void EmitResolvePossiblyDirectEval(Call* expr);