Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Move logic to scope analysis time Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1232 context()->Plug(rax); 1232 context()->Plug(rax);
1233 break; 1233 break;
1234 } 1234 }
1235 1235
1236 case VariableLocation::PARAMETER: 1236 case VariableLocation::PARAMETER:
1237 case VariableLocation::LOCAL: 1237 case VariableLocation::LOCAL:
1238 case VariableLocation::CONTEXT: { 1238 case VariableLocation::CONTEXT: {
1239 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1239 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1240 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context slot" 1240 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context slot"
1241 : "[ Stack slot"); 1241 : "[ Stack slot");
1242 if (NeedsHoleCheckForLoad(proxy)) { 1242 if (proxy->needs_hole_check()) {
1243 // Throw a reference error when using an uninitialized let/const 1243 // Throw a reference error when using an uninitialized let/const
1244 // binding in harmony mode. 1244 // binding in harmony mode.
1245 DCHECK(IsLexicalVariableMode(var->mode())); 1245 DCHECK(IsLexicalVariableMode(var->mode()));
1246 Label done; 1246 Label done;
1247 GetVar(rax, var); 1247 GetVar(rax, var);
1248 __ CompareRoot(rax, Heap::kTheHoleValueRootIndex); 1248 __ CompareRoot(rax, Heap::kTheHoleValueRootIndex);
1249 __ j(not_equal, &done, Label::kNear); 1249 __ j(not_equal, &done, Label::kNear);
1250 __ Push(var->name()); 1250 __ Push(var->name());
1251 __ CallRuntime(Runtime::kThrowReferenceError); 1251 __ CallRuntime(Runtime::kThrowReferenceError);
1252 __ bind(&done); 1252 __ bind(&done);
(...skipping 2295 matching lines...) Expand 10 before | Expand all | Expand 10 after
3548 DCHECK_EQ( 3548 DCHECK_EQ(
3549 isolate->builtins()->OnStackReplacement()->entry(), 3549 isolate->builtins()->OnStackReplacement()->entry(),
3550 Assembler::target_address_at(call_target_address, unoptimized_code)); 3550 Assembler::target_address_at(call_target_address, unoptimized_code));
3551 return ON_STACK_REPLACEMENT; 3551 return ON_STACK_REPLACEMENT;
3552 } 3552 }
3553 3553
3554 } // namespace internal 3554 } // namespace internal
3555 } // namespace v8 3555 } // namespace v8
3556 3556
3557 #endif // V8_TARGET_ARCH_X64 3557 #endif // V8_TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698