Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2411873004: [ignition] Eliminate hole checks where statically possible for loads and stores (Closed)
Patch Set: Move logic to scope analysis time Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1239 matching lines...) Expand 10 before | Expand all | Expand 10 after
1250 context()->Plug(r3); 1250 context()->Plug(r3);
1251 break; 1251 break;
1252 } 1252 }
1253 1253
1254 case VariableLocation::PARAMETER: 1254 case VariableLocation::PARAMETER:
1255 case VariableLocation::LOCAL: 1255 case VariableLocation::LOCAL:
1256 case VariableLocation::CONTEXT: { 1256 case VariableLocation::CONTEXT: {
1257 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode); 1257 DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
1258 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable" 1258 Comment cmnt(masm_, var->IsContextSlot() ? "[ Context variable"
1259 : "[ Stack variable"); 1259 : "[ Stack variable");
1260 if (NeedsHoleCheckForLoad(proxy)) { 1260 if (proxy->needs_hole_check()) {
1261 // Throw a reference error when using an uninitialized let/const 1261 // Throw a reference error when using an uninitialized let/const
1262 // binding in harmony mode. 1262 // binding in harmony mode.
1263 Label done; 1263 Label done;
1264 GetVar(r3, var); 1264 GetVar(r3, var);
1265 __ CompareRoot(r3, Heap::kTheHoleValueRootIndex); 1265 __ CompareRoot(r3, Heap::kTheHoleValueRootIndex);
1266 __ bne(&done); 1266 __ bne(&done);
1267 __ mov(r3, Operand(var->name())); 1267 __ mov(r3, Operand(var->name()));
1268 __ push(r3); 1268 __ push(r3);
1269 __ CallRuntime(Runtime::kThrowReferenceError); 1269 __ CallRuntime(Runtime::kThrowReferenceError);
1270 __ bind(&done); 1270 __ bind(&done);
(...skipping 2384 matching lines...) Expand 10 before | Expand all | Expand 10 after
3655 3655
3656 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address))); 3656 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address)));
3657 3657
3658 DCHECK(interrupt_address == 3658 DCHECK(interrupt_address ==
3659 isolate->builtins()->OnStackReplacement()->entry()); 3659 isolate->builtins()->OnStackReplacement()->entry());
3660 return ON_STACK_REPLACEMENT; 3660 return ON_STACK_REPLACEMENT;
3661 } 3661 }
3662 } // namespace internal 3662 } // namespace internal
3663 } // namespace v8 3663 } // namespace v8
3664 #endif // V8_TARGET_ARCH_PPC 3664 #endif // V8_TARGET_ARCH_PPC
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698