[NoStatePrefetch] Kill renderer after preload scanning

third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 905 matching lines @@
 
   pumpTokenizerIfPossible();
 
   endIfDelayed();
 }
 
 void HTMLDocumentParser::end() {
   ASSERT(!isDetached());
   ASSERT(!isScheduledForResume());
 
+  if (document()->isPrefetchOnly())

[Charlie Harrison, 2016/10/17 13:25:50]

This might make a little more sense in Document::finishedParsing rather than
here. That's generally where document-y things hook parse finish.

[pasko, 2016/10/17 14:25:11]

OK!

Any recommendation on what part of Document::finishedParsing() is more suitable?
I see parser wrap up closer to the end, can put these new checks at the very
end, would it be the most readable place? Would the Document.this still be alive
at that point?

I'll try that after I rebase (which is a non-trivial rebase, mattcary@ added
tests that are relying on old behavior).

[Charlie Harrison, 2016/10/17 14:49:16]

Adding the call to the very end SGTM. Yeah the Document should still be alive by
the end of that method.

[pasko, 2016/10/25 14:49:40]

Done.

+    document()->onPrefetchFinished();
+
   if (m_haveBackgroundParser)
     stopBackgroundParser();
 
   // Informs the the rest of WebCore that parsing is really finished (and
   // deletes this).
   m_treeBuilder->finished();
 
   DocumentParser::stopParsing();
 }
 
@@ skipping 359 matching lines @@
     case Asynchronous:
       m_loadingTaskRunner->postTask(
           BLINK_FROM_HERE,
           WTF::bind(function, std::forward<Ps>(parameters)...));
       return;
   }
   NOTREACHED();
 }
 
 }  // namespace blink