Replace some deprecated usages of readdir_r with readdir

sandbox/linux/services/proc_util.cc

Index: sandbox/linux/services/proc_util.cc
diff --git a/sandbox/linux/services/proc_util.cc b/sandbox/linux/services/proc_util.cc
index b6d58de56489f7f0a92984ee079c623c7cdfabc6..197668e7bb41dc3035422c8bdd29572c2a3f568b 100644
--- a/sandbox/linux/services/proc_util.cc
+++ b/sandbox/linux/services/proc_util.cc
@@ -51,15 +51,23 @@ int ProcUtil::CountOpenFds(int proc_fd) {
   CHECK(dir);
 
   int count = 0;
+#if defined(OS_NACL_NONSFI)

[Jorge Lucangeli Obes, 2016/10/31 15:58:47]

I would add another comment here (and below under the other #if defined()
explaining why this is needed.

Something like:

"NaCl has not implemented readdir(3)."

   struct dirent e;
   struct dirent* de;
   while (!readdir_r(dir.get(), &e, &de) && de) {
-    if (strcmp(e.d_name, ".") == 0 || strcmp(e.d_name, "..") == 0) {
+#else
+  // In all implementations of the C library that Chromium can run with,
+  // concurrent calls to readdir that specify different directory streams are
+  // thread-safe. This is the case here, since the directory stream is scoped to
+  // the current function. See https://codereview.chromium.org/2411833004/#msg3
+  for (struct dirent* de = readdir(dir.get()); de; de = readdir(dir.get())) {
+#endif
+    if (strcmp(de->d_name, ".") == 0 || strcmp(de->d_name, "..") == 0) {
       continue;
     }
 
     int fd_num;
-    CHECK(base::StringToInt(e.d_name, &fd_num));
+    CHECK(base::StringToInt(de->d_name, &fd_num));
     if (fd_num == proc_fd || fd_num == proc_self_fd) {
       continue;
     }
@@ -81,22 +89,30 @@ bool ProcUtil::HasOpenDirectory(int proc_fd) {
   ScopedDIR dir(fdopendir(proc_self_fd));
   CHECK(dir);
 
+#if defined(OS_NACL_NONSFI)
   struct dirent e;
   struct dirent* de;

[Jorge Lucangeli Obes, 2016/10/31 15:58:47]

This can live outside of the define, can't it?

   while (!readdir_r(dir.get(), &e, &de) && de) {
-    if (strcmp(e.d_name, ".") == 0 || strcmp(e.d_name, "..") == 0) {
+#else
+  // In all implementations of the C library that Chromium can run with,
+  // concurrent calls to readdir that specify different directory streams are
+  // thread-safe. This is the case here, since the directory stream is scoped to
+  // the current function. See https://codereview.chromium.org/2411833004/#msg3
+  for (struct dirent* de = readdir(dir.get()); de; de = readdir(dir.get())) {
+#endif
+    if (strcmp(de->d_name, ".") == 0 || strcmp(de->d_name, "..") == 0) {
       continue;
     }
 
     int fd_num;
-    CHECK(base::StringToInt(e.d_name, &fd_num));
+    CHECK(base::StringToInt(de->d_name, &fd_num));
     if (fd_num == proc_fd || fd_num == proc_self_fd) {
       continue;
     }
 
     struct stat s;
     // It's OK to use proc_self_fd here, fstatat won't modify it.
-    CHECK(fstatat(proc_self_fd, e.d_name, &s, 0) == 0);
+    CHECK(fstatat(proc_self_fd, de->d_name, &s, 0) == 0);
     if (S_ISDIR(s.st_mode)) {
       return true;
     }