Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2411833002: Fix negative font rendering on Mac by reversing matrix c component. (Closed)

Created:
4 years, 2 months ago by npm
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix negative font rendering on Mac by reversing matrix c component. Notice that this is just making it analoguous to how it works when the font is positive: the b and d components are reversed. Currently, when the font is negative, only the a component is reversed. The c one needs to be reversed as well. BUG=chromium:653941, pdfium:370 Committed: https://pdfium.googlesource.com/pdfium/+/4ea4281ad5775686317ef53f48eab39898d13d23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M core/fxge/apple/fx_apple_platform.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
npm
PTAL
4 years, 2 months ago (2016-10-11 18:18:38 UTC) #5
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-11 18:44:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411833002/1
4 years, 2 months ago (2016-10-11 18:51:07 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 18:51:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4ea4281ad5775686317ef53f48eab39898d1...

Powered by Google App Engine
This is Rietveld 408576698