Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2411823002: Remove static_cast<base::MessageLoopForUI*> from aw_contents_client_bridge.cc. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove static_cast<base::MessageLoopForUI*> from aw_contents_client_bridge.cc. In preparation for the migration of BrowserThreads to TaskScheduler, we want to remove calls to MessageLoop::current(). MessageLoopForUI::current() is still supported. BUG=650723 Committed: https://crrev.com/ee1e0f0692c8407eb77db45a19633d566821cf25 Cr-Commit-Position: refs/heads/master@{#424713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-11 18:32:54 UTC) #6
Tobias Sargeant
lgtm
4 years, 2 months ago (2016-10-12 10:22:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411823002/1
4 years, 2 months ago (2016-10-12 11:23:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 11:27:23 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 11:29:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee1e0f0692c8407eb77db45a19633d566821cf25
Cr-Commit-Position: refs/heads/master@{#424713}

Powered by Google App Engine
This is Rietveld 408576698