Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2411813005: libyuv GN win64 clang-cl support. (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libyuv GN win64 clang-cl support. fix build warnings in unittests affecting 64 bit clang-cl GN builds. remove I411 support. change YUV destination in unittests to side by side buffers to avoid paging. Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/af87c11c..198bce39 https://chromium.googlesource.com/libyuv/libyuv/+/af87c11c..198bce39 BUG=libyuv:649, libyuv:645 TEST=manually run GN build of win64 clang-cl Committed: https://crrev.com/4002e1e9b523f01816e2da0992187a1b568ec950 Cr-Commit-Position: refs/heads/master@{#424902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
kjellander_chromium
lgtm
4 years, 2 months ago (2016-10-12 21:16:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411813005/1
4 years, 2 months ago (2016-10-12 23:11:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 23:17:13 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 23:19:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4002e1e9b523f01816e2da0992187a1b568ec950
Cr-Commit-Position: refs/heads/master@{#424902}

Powered by Google App Engine
This is Rietveld 408576698