|
|
Chromium Code Reviews
DescriptionRoute DXGI Frame Statistics to VSyncProvider
This leverages new ANGLE implementation of
eglGetSyncValuesCHROMIUM and replaces the current DWM
specific version of VSyncProvider with the default version
which is now mostly shared with Linux implementation.
This doesn't add any new functionality but makes a step
in the right direction with the goal of passing actual
frame statistics back to the browser.
The next step will be to use the VSync system time
returned to VSyncProvider by eglGetSyncValuesCHROMIUM
and expose it as frame time to be used by smoothness
benchmarks.
BUG=614147
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/b5df120a181df5743a1ebd5f7cc6537a00097ee3
Cr-Commit-Position: refs/heads/master@{#424868}
Patch Set 1 #Patch Set 2 : Build error fix #
Messages
Total messages: 34 (28 generated)
Description was changed from ========== Route DXGI Frame Statistics to VSyncProvider BUG=614147 ========== to ========== Route DXGI Frame Statistics to VSyncProvider BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by stanisc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by stanisc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by stanisc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by stanisc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by stanisc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Route DXGI Frame Statistics to VSyncProvider BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Route DXGI Frame Statistics to VSyncProvider This leverages new ANGLE implementation of eglGetSyncValuesCHROMIUM and replaces the current DWM specific version of VSyncProvider with the default version which is now mostly shared with Linux implementation. This doesn't add any new functionality but makes a step in the right direction with the goal of passing actual frame statistics back to the browser. The next step will be to use the VSync system time returned to VSyncProvider by eglGetSyncValuesCHROMIUM and expose it as frame time to be used by smoothness benchmarks. BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Patchset #2 (id:40001) has been deleted
stanisc@chromium.org changed reviewers: + jbauman@chromium.org, piman@chromium.org
jbauman@chromium.org: Please review changes in gpu/ipc/service/image_transport_surface_win.cc piman@chromium.org: Please review all other changes
lgtm
lgtm
The CQ bit was checked by stanisc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Route DXGI Frame Statistics to VSyncProvider This leverages new ANGLE implementation of eglGetSyncValuesCHROMIUM and replaces the current DWM specific version of VSyncProvider with the default version which is now mostly shared with Linux implementation. This doesn't add any new functionality but makes a step in the right direction with the goal of passing actual frame statistics back to the browser. The next step will be to use the VSync system time returned to VSyncProvider by eglGetSyncValuesCHROMIUM and expose it as frame time to be used by smoothness benchmarks. BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Route DXGI Frame Statistics to VSyncProvider This leverages new ANGLE implementation of eglGetSyncValuesCHROMIUM and replaces the current DWM specific version of VSyncProvider with the default version which is now mostly shared with Linux implementation. This doesn't add any new functionality but makes a step in the right direction with the goal of passing actual frame statistics back to the browser. The next step will be to use the VSync system time returned to VSyncProvider by eglGetSyncValuesCHROMIUM and expose it as frame time to be used by smoothness benchmarks. BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Route DXGI Frame Statistics to VSyncProvider This leverages new ANGLE implementation of eglGetSyncValuesCHROMIUM and replaces the current DWM specific version of VSyncProvider with the default version which is now mostly shared with Linux implementation. This doesn't add any new functionality but makes a step in the right direction with the goal of passing actual frame statistics back to the browser. The next step will be to use the VSync system time returned to VSyncProvider by eglGetSyncValuesCHROMIUM and expose it as frame time to be used by smoothness benchmarks. BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Route DXGI Frame Statistics to VSyncProvider This leverages new ANGLE implementation of eglGetSyncValuesCHROMIUM and replaces the current DWM specific version of VSyncProvider with the default version which is now mostly shared with Linux implementation. This doesn't add any new functionality but makes a step in the right direction with the goal of passing actual frame statistics back to the browser. The next step will be to use the VSync system time returned to VSyncProvider by eglGetSyncValuesCHROMIUM and expose it as frame time to be used by smoothness benchmarks. BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b5df120a181df5743a1ebd5f7cc6537a00097ee3 Cr-Commit-Position: refs/heads/master@{#424868} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b5df120a181df5743a1ebd5f7cc6537a00097ee3 Cr-Commit-Position: refs/heads/master@{#424868} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
