Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2411803003: Route DXGI Frame Statistics to VSyncProvider (Closed)

Created:
4 years, 2 months ago by stanisc
Modified:
4 years, 2 months ago
Reviewers:
jbauman, piman
CC:
chromium-reviews, piman+watch_chromium.org, ozone-reviews_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route DXGI Frame Statistics to VSyncProvider This leverages new ANGLE implementation of eglGetSyncValuesCHROMIUM and replaces the current DWM specific version of VSyncProvider with the default version which is now mostly shared with Linux implementation. This doesn't add any new functionality but makes a step in the right direction with the goal of passing actual frame statistics back to the browser. The next step will be to use the VSync system time returned to VSyncProvider by eglGetSyncValuesCHROMIUM and expose it as frame time to be used by smoothness benchmarks. BUG=614147 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b5df120a181df5743a1ebd5f7cc6537a00097ee3 Cr-Commit-Position: refs/heads/master@{#424868}

Patch Set 1 #

Patch Set 2 : Build error fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -100 lines) Patch
M gpu/ipc/service/image_transport_surface_win.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 2 chunks +20 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 3 chunks +25 lines, -36 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.h View 1 2 chunks +10 lines, -4 lines 0 comments Download
M ui/gl/sync_control_vsync_provider.cc View 1 4 chunks +100 lines, -57 lines 0 comments Download

Messages

Total messages: 34 (28 generated)
stanisc
jbauman@chromium.org: Please review changes in gpu/ipc/service/image_transport_surface_win.cc piman@chromium.org: Please review all other changes
4 years, 2 months ago (2016-10-12 20:39:29 UTC) #26
piman
lgtm
4 years, 2 months ago (2016-10-12 21:16:33 UTC) #27
jbauman
lgtm
4 years, 2 months ago (2016-10-12 21:17:56 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411803003/60001
4 years, 2 months ago (2016-10-12 21:29:45 UTC) #30
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-10-12 21:36:05 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:39:33 UTC) #34
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5df120a181df5743a1ebd5f7cc6537a00097ee3
Cr-Commit-Position: refs/heads/master@{#424868}

Powered by Google App Engine
This is Rietveld 408576698