Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Side by Side Diff: Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

Issue 24118003: Pass isolate to v8::Undefined() function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 case WebGLGetInfo::kTypeWebGLTexture: 160 case WebGLGetInfo::kTypeWebGLTexture:
161 return toV8(info.getWebGLTexture(), creationContext, isolate); 161 return toV8(info.getWebGLTexture(), creationContext, isolate);
162 case WebGLGetInfo::kTypeWebGLUnsignedByteArray: 162 case WebGLGetInfo::kTypeWebGLUnsignedByteArray:
163 return toV8(info.getWebGLUnsignedByteArray(), creationContext, isolate); 163 return toV8(info.getWebGLUnsignedByteArray(), creationContext, isolate);
164 case WebGLGetInfo::kTypeWebGLUnsignedIntArray: 164 case WebGLGetInfo::kTypeWebGLUnsignedIntArray:
165 return toV8(info.getWebGLUnsignedIntArray(), creationContext, isolate); 165 return toV8(info.getWebGLUnsignedIntArray(), creationContext, isolate);
166 case WebGLGetInfo::kTypeWebGLVertexArrayObjectOES: 166 case WebGLGetInfo::kTypeWebGLVertexArrayObjectOES:
167 return toV8(info.getWebGLVertexArrayObjectOES(), creationContext, isolat e); 167 return toV8(info.getWebGLVertexArrayObjectOES(), creationContext, isolat e);
168 default: 168 default:
169 notImplemented(); 169 notImplemented();
170 return v8::Undefined(); 170 return v8::Undefined(isolate);
171 } 171 }
172 } 172 }
173 173
174 static v8::Handle<v8::Value> toV8Object(WebGLExtension* extension, v8::Handle<v8 ::Object> contextObject, v8::Isolate* isolate) 174 static v8::Handle<v8::Value> toV8Object(WebGLExtension* extension, v8::Handle<v8 ::Object> contextObject, v8::Isolate* isolate)
175 { 175 {
176 if (!extension) 176 if (!extension)
177 return v8::Null(isolate); 177 return v8::Null(isolate);
178 v8::Handle<v8::Value> extensionObject; 178 v8::Handle<v8::Value> extensionObject;
179 const char* referenceName = 0; 179 const char* referenceName = 0;
180 switch (extension->getName()) { 180 switch (extension->getName()) {
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 { 761 {
762 vertexAttribAndUniformHelperf(args, kVertexAttrib3v); 762 vertexAttribAndUniformHelperf(args, kVertexAttrib3v);
763 } 763 }
764 764
765 void V8WebGLRenderingContext::vertexAttrib4fvMethodCustom(const v8::FunctionCall backInfo<v8::Value>& args) 765 void V8WebGLRenderingContext::vertexAttrib4fvMethodCustom(const v8::FunctionCall backInfo<v8::Value>& args)
766 { 766 {
767 vertexAttribAndUniformHelperf(args, kVertexAttrib4v); 767 vertexAttribAndUniformHelperf(args, kVertexAttrib4v);
768 } 768 }
769 769
770 } // namespace WebCore 770 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8PromiseResolverCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698