[wasm] Let BranchTableIterator::has_next return false if decoder->failed()

[wasm] Let BranchTableIterator::has_next return false if decoder->failed()

R=titzer@chromium.org

Committed: https://crrev.com/52cf416aa812926c4eae86b85276decf17b989b2
Cr-Commit-Position: refs/heads/master@{#40287}

[ahaas, 2016-10-13 13:33:25]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 13:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-10-13 13:46:10]

https://codereview.chromium.org/2411793006/diff/1/src/wasm/ast-decoder.h
File src/wasm/ast-decoder.h (right):

https://codereview.chromium.org/2411793006/diff/1/src/wasm/ast-decoder.h#newc...
src/wasm/ast-decoder.h:237: bool has_next() { return decoder_->ok() && index_ <=
table_count_; }
Does this obviate the previous fix?

[ahaas, 2016-10-13 13:53:44]

https://codereview.chromium.org/2411793006/diff/1/src/wasm/ast-decoder.h
File src/wasm/ast-decoder.h (right):

https://codereview.chromium.org/2411793006/diff/1/src/wasm/ast-decoder.h#newc...
src/wasm/ast-decoder.h:237: bool has_next() { return decoder_->ok() && index_ <=
table_count_; }
On 2016/10/13 at 13:46:10, titzer wrote:
> Does this obviate the previous fix?

This change does not prevent any crashes, it just reduces the time it takes to
decode an invalid function.

[titzer, 2016-10-13 14:02:40]

On 2016/10/13 13:53:44, ahaas wrote:
> https://codereview.chromium.org/2411793006/diff/1/src/wasm/ast-decoder.h
> File src/wasm/ast-decoder.h (right):
> 
>
https://codereview.chromium.org/2411793006/diff/1/src/wasm/ast-decoder.h#newc...
> src/wasm/ast-decoder.h:237: bool has_next() { return decoder_->ok() && index_
<=
> table_count_; }
> On 2016/10/13 at 13:46:10, titzer wrote:
> > Does this obviate the previous fix?
> 
> This change does not prevent any crashes, it just reduces the time it takes to
> decode an invalid function.

lgtm

[commit-bot: I haz the power, 2016-10-13 14:26:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 14:26:42]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-10-13 18:29:17]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 18:32:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-13 18:32:23]

Description was changed from

==========
[wasm] Let BranchTableIterator::has_next return false if decoder->failed()

R=titzer@chromium.org
==========

to

==========
[wasm] Let BranchTableIterator::has_next return false if decoder->failed()

R=titzer@chromium.org

Committed: https://crrev.com/52cf416aa812926c4eae86b85276decf17b989b2
Cr-Commit-Position: refs/heads/master@{#40287}
==========

[commit-bot: I haz the power, 2016-10-13 18:32:24]

Patchset 1 (id:??) landed as
https://crrev.com/52cf416aa812926c4eae86b85276decf17b989b2
Cr-Commit-Position: refs/heads/master@{#40287}